linux-kernel - Re: [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b6c8271-c3b5-4950-abb4-5888c3d4c67f@web.de>
Date: Tue, 24 Jun 2025 21:21:55 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Vincent Mailhol <mailhol.vincent@...adoo.fr>, linux-can@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Chen Ni <nichen@...as.ac.cn>, Marc Kleine-Budde <mkl@...gutronix.de>
Subject: Re: [PATCH] can: ucan: Use usb_endpoint_type() rather than
 duplicating its implementation

>> +++ b/drivers/net/can/usb/ucan.c
>> @@ -1353,16 +1353,14 @@ static int ucan_probe(struct usb_interface *intf,
>>  		ep = &iface_desc->endpoint[i].desc;
>>  
>>  		if (((ep->bEndpointAddress & USB_ENDPOINT_DIR_MASK) != 0) &&
>                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This is:
> 
> 	usb_endpoint_dir_in(ep)

Can the check for a single value like “USB_DIR_IN” be really mapped to
an other value range?
https://elixir.bootlin.com/linux/v6.16-rc3/source/include/uapi/linux/usb/ch9.h#L495-L503

Regards,
Markus