linux-kernel - Re: can: ucan: Use usb_endpoint_type() rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c96a5d2c-0ee1-4e3e-a95d-d38a8f668feb@wanadoo.fr>
Date: Wed, 25 Jun 2025 07:59:24 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Markus Elfring <Markus.Elfring@....de>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Chen Ni <nichen@...as.ac.cn>, Marc Kleine-Budde <mkl@...gutronix.de>,
 linux-can@...r.kernel.org
Subject: Re: can: ucan: Use usb_endpoint_type() rather than duplicating its
 implementation

On 25/06/2025 at 03:28, Markus Elfring wrote:
>> Looking at the helpers in linux/usb/ch9.h,
> 
> Please take another look at known source code mappings.
> 
> Passing code replacements by APIs (for SmPL)?
> https://lore.kernel.org/cocci/481faa1d-7171-4657-8dc0-c37b153e6eaa@web.de/
> https://sympa.inria.fr/sympa/arc/cocci/2025-06/msg00044.html
> 
> 
>> it seems that Coccinelle missed many simplifications.
> 
> Would such software transformations become better supported anyhow?

Maybe?

I am not involved in the development of Coccinelle and thus, I don't have an
answer. Nor do I have the time to read and understand the Coccinelle source code
to which you pointed me to.

My stance is that such static analyzers should never be trusted 100%. The output
is more an indicator. And in this present case, a quick review made it very
clear that Coccinelle saw one simplification but missed two other ones.


Yours sincerely,
Vincent Mailhol