linux-kernel - Re: [PATCH][next] ACPI: APEI: EINJ: Fix less than zero comparison on a size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <685b142c66165_2bbf0029417@iweiny-mobl.notmuch>
Date: Tue, 24 Jun 2025 16:10:04 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Colin Ian King <colin.i.king@...il.com>, "Rafael J . Wysocki"
	<rafael@...nel.org>, Len Brown <lenb@...nel.org>, James Morse
	<james.morse@....com>, Tony Luck <tony.luck@...el.com>, Borislav Petkov
	<bp@...en8.de>, Zaid Alali <zaidal@...amperecomputing.com>, Ira Weiny
	<ira.weiny@...el.com>, <linux-acpi@...r.kernel.org>
CC: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] ACPI: APEI: EINJ: Fix less than zero comparison on
 a size_t variable

Colin Ian King wrote:
> The check for c < 0 is always false because variable c is a size_t which
> is not a signed type. Fix this by making c a ssize_t.
> 
> Fixes: 90711f7bdf76 ("ACPI: APEI: EINJ: Create debugfs files to enter device id and syndrome")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

[snip]