linux-kernel - Re: [PATCH][next] ACPI: APEI: EINJ: Fix less than zero comparison on a size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jF+n0s12FVvqWVAAaUJxFq6q7wkd0Fs2TfTwC+jixeTw@mail.gmail.com>
Date: Thu, 26 Jun 2025 20:51:19 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Ira Weiny <ira.weiny@...el.com>, Colin Ian King <colin.i.king@...il.com>
Cc: Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>, 
	Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>, 
	Zaid Alali <zaidal@...amperecomputing.com>, linux-acpi@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ACPI: APEI: EINJ: Fix less than zero comparison on
 a size_t variable

On Tue, Jun 24, 2025 at 11:09 PM Ira Weiny <ira.weiny@...el.com> wrote:
>
> Colin Ian King wrote:
> > The check for c < 0 is always false because variable c is a size_t which
> > is not a signed type. Fix this by making c a ssize_t.
> >
> > Fixes: 90711f7bdf76 ("ACPI: APEI: EINJ: Create debugfs files to enter device id and syndrome")
> > Signed-off-by: Colin Ian King <colin.i.king@...il.com>
>
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>

Applied, thanks!