linux-kernel - Re: [PATCH v2 01/32] dt-bindings: mfd: samsung,s2mps11: add s2mpg10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a985dd1-e2a1-413e-b38c-c109cc7fbb28@kernel.org>
Date: Tue, 24 Jun 2025 10:51:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Alim Akhtar <alim.akhtar@...sung.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Russell King <linux@...linux.org.uk>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Peter Griffin <peter.griffin@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
 linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rtc@...r.kernel.org
Subject: Re: [PATCH v2 01/32] dt-bindings: mfd: samsung,s2mps11: add s2mpg10

On 31/03/2025 11:50, André Draszik wrote:
> Hi Krzysztof,
> 
> On Mon, 2025-03-31 at 09:34 +0200, Krzysztof Kozlowski wrote:
>> On Fri, Mar 28, 2025 at 01:28:47PM +0000, André Draszik wrote:
>>>  allOf:
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            const: samsung,s2mpg10-pmic
>>> +    then:
>>> +      properties:
>>> +        reg: false
>>> +        samsung,s2mps11-acokb-ground: false
>>> +        samsung,s2mps11-wrstbi-ground: false
>>> +
>>> +      oneOf:
>>> +        - required: [interrupts]
>>> +        - required: [interrupts-extended]
>>
>> Drop, you should require only interrupts.
> 
> As mentioned in the commit message comments, it doesn't work with
> just interrupts. It appears that dtschema's fixups.py doesn't
> handle this case. With just interrupts, DT validation will fail
> if the DT uses interrupts-extended. There was at least one other
> binding that specified interrupts in the same way, so I went with
> the same approach.

Please add a comment about this above oneOf.


Best regards,
Krzysztof