linux-kernel - Re: [RFC PATCH v7 12/37] x86/apic: KVM: Move lapic get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFwBpmO3OSCsAEOx@google.com>
Date: Wed, 25 Jun 2025 07:03:18 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Neeraj Upadhyay <Neeraj.Upadhyay@....com>
Cc: linux-kernel@...r.kernel.org, bp@...en8.de, tglx@...utronix.de, 
	mingo@...hat.com, dave.hansen@...ux.intel.com, Thomas.Lendacky@....com, 
	nikunj@....com, Santosh.Shukla@....com, Vasant.Hegde@....com, 
	Suravee.Suthikulpanit@....com, David.Kaplan@....com, x86@...nel.org, 
	hpa@...or.com, peterz@...radead.org, pbonzini@...hat.com, kvm@...r.kernel.org, 
	kirill.shutemov@...ux.intel.com, huibo.wang@....com, naveen.rao@....com, 
	francescolavra.fl@...il.com, tiala@...rosoft.com
Subject: Re: [RFC PATCH v7 12/37] x86/apic: KVM: Move lapic get/set_reg()
 helpers to common code

On Tue, Jun 10, 2025, Neeraj Upadhyay wrote:
> Move the apic_get_reg() and apic_set_reg() helper functions to
> apic.h in order to reuse them in the Secure AVIC guest apic driver
> in later patches to read/write 32-bit registers from/to the APIC
> backing page.

Please squash this with the next patch that moves apic_{g,s}et_reg64().  Calling
out the need to access 32-bit registers is weird and confusing, and gives the
impression that the kernel doesn't need the 64-bit accessors, which is obviously
not true.