[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <685c13c5.050a0220.38a39d.dcf8@mx.google.com>
Date: Wed, 25 Jun 2025 10:20:36 -0500
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: gregkh@...uxfoundation.org, Benjamin.Cheatham@....com,
Jonathan.Cameron@...wei.com, dakr@...nel.org,
dan.j.williams@...el.com, linux-acpi@...r.kernel.org,
linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org,
marc.herbert@...ux.intel.com, rafael.j.wysocki@...el.com,
rafael@...nel.org, sudeep.holla@....com,
Kees Cook <kees@...nel.org>
Subject: Re: [PATCH] driver core: faux: fix Undefined Behavior in
faux_device_destroy()
On Sat, Jun 14, 2025 at 12:50:37PM +0200, Miguel Ojeda wrote:
> On Fri, 13 Jun 2025 20:33:42 -0400 Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > Great writeup, but as Miguel says, this isn't needed at all, the kernel
> > relies on the compiler to be sane :)
>
> We may still want to clean them up, e.g. for tooling -- Kees/Dan: do we?
> e.g. I see a similar case with discussion at:
>
> https://lore.kernel.org/lkml/3f1e7aaa-501a-44f1-8122-28e9efa0a33c@web.de/
>
> Which in the end was picked up as commit 2df2c0caaecf ("fbdev: au1100fb:
> Move a variable assignment behind a null pointer check").
Putting the declarations at the top was always just a style preference.
Putting declarations at the top causes issues for __cleanup magic and
also bcachefs puts the declarations where ever it wants, but otherwise
people generally still put the declarations at the stop.
regards,
dan carpenter
Powered by blists - more mailing lists