linux-kernel - [PATCH v2 3/5] nvmet: Remove redundant assignment of error code in nvmet_ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250625041643.174110-4-alok.a.tiwari@oracle.com>
Date: Tue, 24 Jun 2025 21:16:32 -0700
From: Alok Tiwari <alok.a.tiwari@...cle.com>
To: linux-nvme@...ts.infradead.org, rdunlap@...radead.org, kbusch@...nel.org,
        axboe@...nel.dk, hch@....de, sagi@...mberg.me, kch@...dia.com,
        nilay@...ux.ibm.com, corbet@....net
Cc: alok.a.tiwari@...cle.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH v2 3/5] nvmet: Remove redundant assignment of error code in nvmet_ns_enable()

removing the unnecessary ret = -EMFILE; assignment since it is
immediately overwritten by the result of nvmet_bdev_ns_enable()
The initial value(-EMFILE) is redundant because it has no effect
on the code logic or outcome.

Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
---
v2
no changes only added Reviewed-by
---
 drivers/nvme/target/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index 175c5b6d4dd58..884286f90688a 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -581,8 +581,6 @@ int nvmet_ns_enable(struct nvmet_ns *ns)
 	if (ns->enabled)
 		goto out_unlock;
 
-	ret = -EMFILE;
-
 	ret = nvmet_bdev_ns_enable(ns);
 	if (ret == -ENOTBLK)
 		ret = nvmet_file_ns_enable(ns);
-- 
2.46.0