linux-kernel - Re: [PATCH v14 10/32] x86/resctrl: Add support to enable/disable AMD ABMC feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1adaf6c0-1449-44a5-9411-9a098c1bcb78@amd.com>
Date: Wed, 25 Jun 2025 14:50:44 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
 tony.luck@...el.com, Dave.Martin@....com, james.morse@....com,
 tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: x86@...nel.org, hpa@...or.com, akpm@...ux-foundation.org,
 rostedt@...dmis.org, paulmck@...nel.org, thuth@...hat.com, ardb@...nel.org,
 gregkh@...uxfoundation.org, seanjc@...gle.com, thomas.lendacky@....com,
 pawan.kumar.gupta@...ux.intel.com, manali.shukla@....com,
 perry.yuan@....com, kai.huang@...el.com, peterz@...radead.org,
 xiaoyao.li@...el.com, kan.liang@...ux.intel.com, mario.limonciello@....com,
 xin3.li@...el.com, gautham.shenoy@....com, xin@...or.com,
 chang.seok.bae@...el.com, fenghuay@...dia.com, peternewman@...gle.com,
 maciej.wieczor-retman@...el.com, eranian@...gle.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v14 10/32] x86/resctrl: Add support to enable/disable AMD
 ABMC feature

Hi Reinette,

On 6/24/25 17:37, Reinette Chatre wrote:
> Hi Babu,
> 
> On 6/13/25 2:04 PM, Babu Moger wrote:
>> +/**
>> + * resctrl_arch_mbm_cntr_assign_set() - Configure the MBM counter assignment mode.
>> + * @r:		Pointer to the resource structure.
>> + * @enable:	Set to true to enable, false to disable the assignment mode.
>> + *
>> + * Return:
>> + * 0 on success, non-zero on failure.
> 
>  * 0 on success, <0 on failure.

Sure.

0 on success, < 0 on error.

> 
> (Just to be specific that it will be negative. Could also be "on error" to match
> similar in same file, but resctrl is not consistent in this regard.)
> 
-- 
Thanks
Babu Moger