linux-kernel - RE: [PATCH v14 02/32] x86,fs/resctrl: Consolidate monitor event descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6083670E3A7FF6AE8881EBC2FC7BA@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Wed, 25 Jun 2025 20:12:39 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "babu.moger@....com" <babu.moger@....com>, "Chatre, Reinette"
	<reinette.chatre@...el.com>, "corbet@....net" <corbet@....net>,
	"Dave.Martin@....com" <Dave.Martin@....com>, "james.morse@....com"
	<james.morse@....com>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC: "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>, "paulmck@...nel.org"
	<paulmck@...nel.org>, "thuth@...hat.com" <thuth@...hat.com>,
	"ardb@...nel.org" <ardb@...nel.org>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "seanjc@...gle.com" <seanjc@...gle.com>,
	"thomas.lendacky@....com" <thomas.lendacky@....com>,
	"pawan.kumar.gupta@...ux.intel.com" <pawan.kumar.gupta@...ux.intel.com>,
	"manali.shukla@....com" <manali.shukla@....com>, "perry.yuan@....com"
	<perry.yuan@....com>, "Huang, Kai" <kai.huang@...el.com>,
	"peterz@...radead.org" <peterz@...radead.org>, "Li, Xiaoyao"
	<xiaoyao.li@...el.com>, "kan.liang@...ux.intel.com"
	<kan.liang@...ux.intel.com>, "mario.limonciello@....com"
	<mario.limonciello@....com>, "Li, Xin3" <xin3.li@...el.com>,
	"gautham.shenoy@....com" <gautham.shenoy@....com>, "xin@...or.com"
	<xin@...or.com>, "Bae, Chang Seok" <chang.seok.bae@...el.com>,
	"fenghuay@...dia.com" <fenghuay@...dia.com>, "peternewman@...gle.com"
	<peternewman@...gle.com>, "Wieczor-Retman, Maciej"
	<maciej.wieczor-retman@...el.com>, "Eranian, Stephane" <eranian@...gle.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v14 02/32] x86,fs/resctrl: Consolidate monitor event
 descriptions

> I'm working on fixing these additional issues. I'll ping you when I
> push to my GIT tree.

Pushed to the rdt-aet-v5.5 branch of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git

You need these four commits:

2feb4e5716f7 x86,fs/resctrl: Prepare for more monitor events
3a86f90a9b81 x86/resctrl: Remove 'rdt_mon_features' global variable
3e720a9d3b46 x86,fs/resctrl: Replace architecture event enabled checks
ed06edafba78 x86,fs/resctrl: Consolidate monitor event descriptions

Only first and last have substantive changes. Middle two might just have
changed line numbers because of the first.

To fix the "landmine " code using "while (--idx)" I added a macro to
do the iteration (originally suggested by Fenghua, but there were
only two places to use it then, so it didn't seem worth it.)

Now there are 4 ... so here's my macro:

/* Iterate over memory bandwidth arrays in domain structures */
#define for_each_mbm_idx(idx)                                   \
        for (idx = 0; idx < QOS_NUM_L3_MBM_EVENTS; idx++)

Hopefully enough different from:

/* Iterate over all memory bandwidth events */
#define for_each_mbm_event_id(eventid)                          \
        for (eventid = QOS_L3_MBM_TOTAL_EVENT_ID;               \
             eventid <= QOS_L3_MBM_LOCAL_EVENT_ID; eventid++)

to not cause confusion.

-Tony