linux-kernel - Re: [PATCH 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07f1d17d-5a14-4a87-90a2-5bd181ccce3a@mleia.com>
Date: Wed, 25 Jun 2025 03:33:08 +0300
From: Vladimir Zapolskiy <vz@...ia.com>
To: Frank Li <Frank.Li@....com>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Guo Ren <guoren@...nel.org>,
 "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..."
 <linux-input@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "moderated list:ARM/LPC32XX SOC SUPPORT"
 <linux-arm-kernel@...ts.infradead.org>,
 open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: input: touchscreen: convert
 lpc32xx-tsc.txt to yaml format

On 6/24/25 23:11, Frank Li wrote:
> Convert lpc32xx-tsc.txt to yaml format.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>   .../input/touchscreen/lpc32xx-tsc.txt         | 16 --------
>   .../input/touchscreen/nxp,lpc3220-tsc.yaml    | 39 +++++++++++++++++++
>   2 files changed, 39 insertions(+), 16 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
>   create mode 100644 Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt b/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
> deleted file mode 100644
> index 41cbf4b7a670d..0000000000000
> --- a/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -* NXP LPC32xx SoC Touchscreen Controller (TSC)
> -
> -Required properties:
> -- compatible: must be "nxp,lpc3220-tsc"
> -- reg: physical base address of the controller and length of memory mapped
> -  region.
> -- interrupts: The TSC/ADC interrupt
> -
> -Example:
> -
> -	tsc@...48000 {
> -		compatible = "nxp,lpc3220-tsc";
> -		reg = <0x40048000 0x1000>;
> -		interrupt-parent = <&mic>;
> -		interrupts = <39 0>;
> -	};
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml
> new file mode 100644
> index 0000000000000..34cb8b68216aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/nxp,lpc3220-tsc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LPC32xx SoC Touchscreen Controller (TSC)
> +
> +maintainers:
> +  - Frank Li <Frank.Li@....com>
> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-tsc
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts

"clocks" property is mandatory, the old scheme is broken in this sense.

Please either fix the old scheme before conversion, or at least mention
the difference between the old scheme and the new one in the commit
message, and please add "clocks" to the list of required properties.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    touchscreen@...48000 {
> +        compatible = "nxp,lpc3220-tsc";
> +        reg = <0x40048000 0x1000>;
> +        interrupt-parent = <&mic>;
> +        interrupts = <39 0>;
> +    };

--
Best wishes,
Vladimir