linux-kernel - Re: [PATCH v3 3/6] spi: spi-fsl-dspi: Stub out DMA functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506251332.thYB4ced-lkp@intel.com>
Date: Wed, 25 Jun 2025 13:25:08 +0800
From: kernel test robot <lkp@...el.com>
To: James Clark <james.clark@...aro.org>,
	Vladimir Oltean <olteanv@...il.com>,
	Mark Brown <broonie@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Larisa Grigore <larisa.grigore@....com>,
	Frank Li <Frank.li@....com>, Christoph Hellwig <hch@....de>
Cc: oe-kbuild-all@...ts.linux.dev, linux-spi@...r.kernel.org,
	imx@...ts.linux.dev, linux-kernel@...r.kernel.org,
	James Clark <james.clark@...aro.org>
Subject: Re: [PATCH v3 3/6] spi: spi-fsl-dspi: Stub out DMA functions

Hi James,

kernel test robot noticed the following build errors:

[auto build test ERROR on 4f326fa6236787ca516ea6eab8e5e9dc5c236f03]

url:    https://github.com/intel-lab-lkp/linux/commits/James-Clark/spi-spi-fsl-dspi-Clear-completion-counter-before-initiating-transfer/20250624-183952
base:   4f326fa6236787ca516ea6eab8e5e9dc5c236f03
patch link:    https://lore.kernel.org/r/20250624-james-nxp-spi-dma-v3-3-e7d574f5f62c%40linaro.org
patch subject: [PATCH v3 3/6] spi: spi-fsl-dspi: Stub out DMA functions
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250625/202506251332.thYB4ced-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250625/202506251332.thYB4ced-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506251332.thYB4ced-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/spi/spi-fsl-dspi.c: In function 'dspi_dma_xfer':
>> drivers/spi/spi-fsl-dspi.c:729:9: error: 'sdpi' undeclared (first use in this function); did you mean 'dspi'?
     729 |         sdpi->cur_msg->status = -EINVAL;
         |         ^~~~
         |         dspi
   drivers/spi/spi-fsl-dspi.c:729:9: note: each undeclared identifier is reported only once for each function it appears in
   drivers/spi/spi-fsl-dspi.c: At top level:
>> drivers/spi/spi-fsl-dspi.c:474:12: warning: 'dspi_pop_tx_pushr' defined but not used [-Wunused-function]
     474 | static u32 dspi_pop_tx_pushr(struct fsl_dspi *dspi)
         |            ^~~~~~~~~~~~~~~~~


vim +729 drivers/spi/spi-fsl-dspi.c

   705	
   706	static void dspi_release_dma(struct fsl_dspi *dspi)
   707	{
   708		int dma_bufsize = dspi->devtype_data->fifo_size * 2;
   709		struct fsl_dspi_dma *dma = dspi->dma;
   710	
   711		if (!dma)
   712			return;
   713	
   714		if (dma->chan_tx) {
   715			dma_free_coherent(dma->chan_tx->device->dev, dma_bufsize,
   716					  dma->tx_dma_buf, dma->tx_dma_phys);
   717			dma_release_channel(dma->chan_tx);
   718		}
   719	
   720		if (dma->chan_rx) {
   721			dma_free_coherent(dma->chan_rx->device->dev, dma_bufsize,
   722					  dma->rx_dma_buf, dma->rx_dma_phys);
   723			dma_release_channel(dma->chan_rx);
   724		}
   725	}
   726	#else
   727	static void dspi_dma_xfer(struct fsl_dspi *dspi)
   728	{
 > 729		sdpi->cur_msg->status = -EINVAL;
   730	}
   731	static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
   732	{
   733		dev_err(&dspi->pdev->dev, "DMA support not enabled in kernel\n");
   734		return -EINVAL;
   735	}
   736	static void dspi_release_dma(struct fsl_dspi *dspi) {}
   737	#endif
   738	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki