linux-kernel - Re: [PATCH v3 6/6] spi: spi-fsl-dspi: Report FIFO overflows as errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506251415.Cj026uIP-lkp@intel.com>
Date: Wed, 25 Jun 2025 15:10:33 +0800
From: kernel test robot <lkp@...el.com>
To: James Clark <james.clark@...aro.org>,
	Vladimir Oltean <olteanv@...il.com>,
	Mark Brown <broonie@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Larisa Grigore <larisa.grigore@....com>,
	Frank Li <Frank.li@....com>, Christoph Hellwig <hch@....de>
Cc: oe-kbuild-all@...ts.linux.dev, linux-spi@...r.kernel.org,
	imx@...ts.linux.dev, linux-kernel@...r.kernel.org,
	James Clark <james.clark@...aro.org>
Subject: Re: [PATCH v3 6/6] spi: spi-fsl-dspi: Report FIFO overflows as errors

Hi James,

kernel test robot noticed the following build errors:

[auto build test ERROR on 4f326fa6236787ca516ea6eab8e5e9dc5c236f03]

url:    https://github.com/intel-lab-lkp/linux/commits/James-Clark/spi-spi-fsl-dspi-Clear-completion-counter-before-initiating-transfer/20250624-183952
base:   4f326fa6236787ca516ea6eab8e5e9dc5c236f03
patch link:    https://lore.kernel.org/r/20250624-james-nxp-spi-dma-v3-6-e7d574f5f62c%40linaro.org
patch subject: [PATCH v3 6/6] spi: spi-fsl-dspi: Report FIFO overflows as errors
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250625/202506251415.Cj026uIP-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250625/202506251415.Cj026uIP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506251415.Cj026uIP-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/spi/spi-fsl-dspi.c: In function 'dspi_dma_xfer':
   drivers/spi/spi-fsl-dspi.c:792:9: error: 'sdpi' undeclared (first use in this function); did you mean 'dspi'?
     792 |         sdpi->cur_msg->status = -EINVAL;
         |         ^~~~
         |         dspi
   drivers/spi/spi-fsl-dspi.c:792:9: note: each undeclared identifier is reported only once for each function it appears in
   drivers/spi/spi-fsl-dspi.c: In function 'dspi_poll':
>> drivers/spi/spi-fsl-dspi.c:1086:49: error: implicit declaration of function 'dspi_fifo_error'; did you mean 'dspi_fifo_write'? [-Wimplicit-function-declaration]
    1086 |                         dspi->cur_msg->status = dspi_fifo_error(dspi, spi_sr);
         |                                                 ^~~~~~~~~~~~~~~
         |                                                 dspi_fifo_write
   drivers/spi/spi-fsl-dspi.c: At top level:
   drivers/spi/spi-fsl-dspi.c:474:12: warning: 'dspi_pop_tx_pushr' defined but not used [-Wunused-function]
     474 | static u32 dspi_pop_tx_pushr(struct fsl_dspi *dspi)
         |            ^~~~~~~~~~~~~~~~~


vim +1086 drivers/spi/spi-fsl-dspi.c

  1072	
  1073	static void dspi_poll(struct fsl_dspi *dspi)
  1074	{
  1075		int tries = 1000;
  1076		u32 spi_sr;
  1077	
  1078		while (dspi->len) {
  1079			do {
  1080				regmap_read(dspi->regmap, SPI_SR, &spi_sr);
  1081				regmap_write(dspi->regmap, SPI_SR, spi_sr);
  1082	
  1083				if (spi_sr & SPI_SR_CMDTCF)
  1084					break;
  1085	
> 1086				dspi->cur_msg->status = dspi_fifo_error(dspi, spi_sr);
  1087				if (dspi->cur_msg->status)
  1088					return;
  1089			} while (--tries);
  1090	
  1091			if (!tries) {
  1092				dspi->cur_msg->status = -ETIMEDOUT;
  1093				return;
  1094			}
  1095	
  1096			dspi_rxtx(dspi);
  1097		}
  1098	
  1099		dspi->cur_msg->status = 0;
  1100	}
  1101	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki