linux-kernel - RE: [PATCH 07/10] mei: vsc: Unset the event callback on remove and probe errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB6366F0684A781A9F0EF1AA3EED7BA@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Wed, 25 Jun 2025 10:01:02 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: Hans de Goede <hansg@...nel.org>, Sakari Ailus
	<sakari.ailus@...ux.intel.com>, Stanislaw Gruszka
	<stanislaw.gruszka@...ux.intel.com>
CC: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 07/10] mei: vsc: Unset the event callback on remove and
 probe errors

> Subject: [PATCH 07/10] mei: vsc: Unset the event callback on remove and
> probe errors
> 
> Make mei_vsc_remove() properly unset the callback to avoid a dead callback
> sticking around after probe errors or unbinding of the platform driver.
> 

Reviewed-by: Alexander Usyskin <alexander.usyskin@...el.com>

> Fixes: 386a766c4169 ("mei: Add MEI hardware support for IVSC device")
> Signed-off-by: Hans de Goede <hansg@...nel.org>
> ---
>  drivers/misc/mei/platform-vsc.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vsc.c
> index 1ac85f0251c5..b2b5a20ae3fa 100644
> --- a/drivers/misc/mei/platform-vsc.c
> +++ b/drivers/misc/mei/platform-vsc.c
> @@ -380,6 +380,8 @@ static int mei_vsc_probe(struct platform_device
> *pdev)
>  err_cancel:
>  	mei_cancel_work(mei_dev);
> 
> +	vsc_tp_register_event_cb(tp, NULL, NULL);
> +
>  	mei_disable_interrupts(mei_dev);
> 
>  	return ret;
> @@ -388,11 +390,14 @@ static int mei_vsc_probe(struct platform_device
> *pdev)
>  static void mei_vsc_remove(struct platform_device *pdev)
>  {
>  	struct mei_device *mei_dev = platform_get_drvdata(pdev);
> +	struct mei_vsc_hw *hw = mei_dev_to_vsc_hw(mei_dev);
> 
>  	pm_runtime_disable(mei_dev->dev);
> 
>  	mei_stop(mei_dev);
> 
> +	vsc_tp_register_event_cb(hw->tp, NULL, NULL);
> +
>  	mei_disable_interrupts(mei_dev);
> 
>  	mei_deregister(mei_dev);
> --
> 2.49.0