linux-kernel - Re: [PATCH] EDAC: mem_repair: reduce stack usage in edac_mem_repair_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250626143326.GDaF1aNlhXCRvNK43n@fat_crate.local>
Date: Thu, 26 Jun 2025 16:33:26 +0200
From: Borislav Petkov <bp@...en8.de>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Tony Luck <tony.luck@...el.com>, Shiju Jose <shiju.jose@...wei.com>,
	Arnd Bergmann <arnd@...db.de>, James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>, Dave Jiang <dave.jiang@...el.com>,
	Alison Schofield <alison.schofield@...el.com>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC: mem_repair: reduce stack usage in
 edac_mem_repair_get_desc()

On Fri, Jun 20, 2025 at 01:41:28PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Constructing an array on the stack adds complexity and can exceed the
> warning limit for per-function stack usage:
> 
> drivers/edac/mem_repair.c:361:5: error: stack frame size (1296) exceeds limit (1280) in 'edac_mem_repair_get_desc' [-Werror,-Wframe-larger-than]
> 
> Change this to have the actual attribute array allocated statically
> and then just add the instance number on the per-instance copy.
> 
> Fixes: 699ea5219c4b ("EDAC: Add a memory repair control feature")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/edac/mem_repair.c | 56 +++++++++++++++------------------------
>  1 file changed, 22 insertions(+), 34 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette