| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <wcmalvywoginosy5pp7wskgdzjbwbydividmk4dtwguoltiobf@muw5lzkvgu5c>
Date: Thu, 26 Jun 2025 08:13:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexey Klimov <alexey.klimov@...aro.org>
Cc: Srinivas Kandagatla <srini@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Stephen Boyd <sboyd@...nel.org>, Lee Jones <lee@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, linux-arm-msm@...r.kernel.org, linux-sound@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio
codec
On Thu, Jun 26, 2025 at 12:50:29AM +0100, Alexey Klimov wrote:
> The audio codec IC is found on Qualcomm PM4125/PM2250 PMIC.
> It has TX and RX soundwire slave devices hence two files
> are added.
>
> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> ---
> .../bindings/sound/qcom,pm4125-codec.yaml | 147 +++++++++++++++++++++
> .../devicetree/bindings/sound/qcom,pm4125-sdw.yaml | 86 ++++++++++++
> 2 files changed, 233 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.yaml b/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..1b6ce8d4397b4c1c048899bd2cc4d02318cc46c9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.yaml
> @@ -0,0 +1,147 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/qcom,pm4125-codec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm PM4125 Audio Codec
> +
> +maintainers:
> + - Alexey Klimov <alexey.klimov@...aro.org>
> +
> +description:
> + The audio codec IC found on Qualcomm PM4125/PM2250 PMIC.
> + It has RX and TX Soundwire slave devices.
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: qcom,pm4125-codec
> +
> + reg:
> + description:
> + Specifies the SPMI base address for the audio codec peripherals. The
> + address space contains reset register needed to power-on the codec.
> + maxItems: 1
> +
> + reg-names:
> + maxItems: 1
> +
> + vdd-io-supply:
> + description: A reference to the 1.8V I/O supply
> +
> + vdd-cp-supply:
> + description: A reference to the charge pump I/O supply
> +
> + vdd-mic-bias-supply:
> + description: A reference to the 3.3V mic bias supply
> +
> + vdd-pa-vpos-supply:
> + description: A reference to the PA VPOS supply
> +
> + qcom,tx-device:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: A reference to Soundwire tx device phandle
> +
> + qcom,rx-device:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: A reference to Soundwire rx device phandle
> +
> + qcom,micbias1-microvolt:
> + description: micbias1 voltage
> + minimum: 1800000
> + maximum: 2850000
> +
> + qcom,micbias2-microvolt:
> + description: micbias2 voltage
> + minimum: 1800000
> + maximum: 2850000
> +
> + qcom,micbias3-microvolt:
> + description: micbias3 voltage
> + minimum: 1800000
> + maximum: 2850000
> +
> + qcom,mbhc-buttons-vthreshold-microvolt:
> + description:
> + Array of 8 Voltage threshold values corresponding to headset
> + button0 - button7
> + minItems: 8
> + maxItems: 8
> +
> + '#sound-dai-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - vdd-io-supply
> + - vdd-cp-supply
> + - vdd-mic-bias-supply
> + - vdd-pa-vpos-supply
> + - qcom,tx-device
> + - qcom,rx-device
> + - qcom,micbias1-microvolt
> + - qcom,micbias2-microvolt
> + - qcom,micbias3-microvolt
> + - "#sound-dai-cells"
Keep consistent quotes, either ' or "
> +
> +additionalProperties: false
This has to unevaluatedProperties
> +
> +examples:
> + - |
> + #include <dt-bindings/spmi/spmi.h>
> +
> + spmi {
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + pmic@0 {
pmic {
> + compatible = "qcom,pm8916", "qcom,spmi-pmic";
Drop, you have warnings here.
> + reg = <0x0 SPMI_USID>;
Drop
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + audio-codec@...0 {
> + compatible = "qcom,pm4125-codec";
> + reg = <0xf000>;
> + vdd-io-supply = <&pm4125_l15>;
> + vdd-cp-supply = <&pm4125_s4>;
> + vdd-pa-vpos-supply = <&pm4125_s4>;
> + vdd-mic-bias-supply = <&pm4125_l22>;
> + qcom,micbias1-microvolt = <1800000>;
> + qcom,micbias2-microvolt = <1800000>;
> + qcom,micbias3-microvolt = <1800000>;
> + qcom,rx-device = <&pm4125_rx>;
> + qcom,tx-device = <&pm4125_tx>;
> + #sound-dai-cells = <1>;
> + };
> + };
> + };
> +
> + /* ... */
> +
> + soundwire@...0000 {
Drop this and next one.
> + reg = <0x0a610000 0x2000>;
> + #address-cells = <2>;
> + #size-cells = <0>;
> + pm4125_rx: audio-codec@0,4 {
> + compatible = "sdw20217010c00";
> + reg = <0 4>;
> + qcom,rx-port-mapping = <1 3>;
> + };
> + };
> +
> + soundwire@...0000 {
> + reg = <0x0a740000 0x2000>;
> + #address-cells = <2>;
> + #size-cells = <0>;
> + pm4125_tx: audio-codec@0,3 {
> + compatible = "sdw20217010c00";
> + reg = <0 3>;
> + qcom,tx-port-mapping = <1 1>;
> + };
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml b/Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..7241d2ab5dcf4a0d5f25a75acb33a335f93d3b5e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml
> @@ -0,0 +1,86 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/qcom,pm4125-sdw.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SoundWire Slave devices on PM4125/PM2250 PMIC audio codec.
> +
> +maintainers:
> + - Alexey Klimov <alexey.klimov@...aro.org>
> +
> +description: |
Drop |
> + The audio codec IC found on Qualcomm PM4125/PM2250 PMICs.
> + It has RX and TX Soundwire slave devices. This bindings is for the
> + slave devices.
Last sentence is redundant and makes no sense. Codec has only slave
devices, so how this can be anything else than for slave devices?
> +
> +properties:
> + compatible:
> + const: sdw20217010c00
> +
> + reg:
> + maxItems: 1
> +
> + qcom,tx-port-mapping:
> + description: |
> + Specifies static port mapping between device and host tx ports.
> + In the order of the device port index which are adc1_port, adc23_port,
> + dmic03_mbhc_port, dmic46_port.
> + Supports maximum 2 tx soundwire ports.
> +
> + PM4125 TX Port 1 (ADC1,2 & DMIC0 & MBHC) <=> SWR0 Port 1
> + PM4125 TX Port 2 (ADC1 & DMIC0,1,2 & MBHC) <=> SWR0 Port 2
> +
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 2
> + maxItems: 2
> + items:
> + enum: [1, 2, 3, 4]
> +
> + qcom,rx-port-mapping:
> + description: |
> + Specifies static port mapping between device and host rx ports.
> + In the order of device port index which are hph_port, clsh_port,
> + comp_port, lo_port, dsd port.
> + Supports maximum 2 rx soundwire ports.
> +
> + PM4125 RX Port 1 (HPH_L/R) <==> SWR1 Port 1 (HPH_L/R)
> + PM4125 RX Port 2 (COMP_L/R) <==> SWR1 Port 3 (COMP_L/R)
> +
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 2
> + maxItems: 2
> + items:
> + enum: [1, 2, 3, 4, 5]
> +
> +required:
> + - compatible
> + - reg
rx and tx are excluding, so this should be here encoded.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soundwire@...0000 {
> + reg = <0x0a610000 0x2000>;
> + #address-cells = <2>;
> + #size-cells = <0>;
> + pm4125_rx: codec@0,1 {
> + compatible = "sdw20217010c00";
> + reg = <0 1>;
> + qcom,rx-port-mapping = <1 3>;
> + };
> + };
> +
> + soundwire@...0000 {
> + reg = <0x0a740000 0x2000>;
One example is enough, they are the same.
> + #address-cells = <2>;
> + #size-cells = <0>;
> + pm4125_tx: codec@0,1 {
> + compatible = "sdw20217010c00";
> + reg = <0 1>;
> + qcom,tx-port-mapping = <1 1>;
> + };
> + };
> +
> +...
>
> --
> 2.47.2
>
Powered by blists - more mailing lists