linux-kernel - Re: [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175090145961.2702141.17071553013552846812.robh@kernel.org>
Date: Wed, 25 Jun 2025 20:30:59 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Alexey Klimov <alexey.klimov@...aro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>, 
 devicetree@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>, 
 linux-arm-msm@...r.kernel.org, Srinivas Kandagatla <srini@...nel.org>, 
 Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>, 
 linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Stephen Boyd <sboyd@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 Lee Jones <lee@...nel.org>, linux-sound@...r.kernel.org, 
 Liam Girdwood <lgirdwood@...il.com>, 
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio
 codec


On Thu, 26 Jun 2025 00:50:29 +0100, Alexey Klimov wrote:
> The audio codec IC is found on Qualcomm PM4125/PM2250 PMIC.
> It has TX and RX soundwire slave devices hence two files
> are added.
> 
> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> ---
>  .../bindings/sound/qcom,pm4125-codec.yaml          | 147 +++++++++++++++++++++
>  .../devicetree/bindings/sound/qcom,pm4125-sdw.yaml |  86 ++++++++++++
>  2 files changed, 233 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.example.dtb: pmic@0 (qcom,pm8916): audio-codec@...0: 'qcom,micbias1-microvolt', 'qcom,micbias2-microvolt', 'qcom,micbias3-microvolt', 'qcom,rx-device', 'qcom,tx-device', 'vdd-cp-supply', 'vdd-io-supply', 'vdd-mic-bias-supply', 'vdd-pa-vpos-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.example.dtb: pmic@0 (qcom,pm8916): audio-codec@...0:compatible:0: 'qcom,pm8916-wcd-analog-codec' was expected
	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250626-pm4125_audio_codec_v1-v1-1-e52933c429a0@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.