[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a6e27c0e-0703-4444-b6e7-d4db1340e802@axiado.com>
Date: Thu, 26 Jun 2025 01:31:47 +0000
From: Harshit Shah <hshah@...ado.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
<brgl@...ev.pl>, Arnd Bergmann <arnd@...db.de>, Catalin Marinas
<catalin.marinas@....com>, Will Deacon <will@...nel.org>, Jan Kotas
<jank@...ence.com>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-gpio@...r.kernel.org"
<linux-gpio@...r.kernel.org>, "soc@...ts.linux.dev" <soc@...ts.linux.dev>
Subject: Re: [PATCH v3 5/7] arm64: dts: axiado: Add initial support for AX3000
SoC and eval board
On 6/24/2025 11:05 PM, Krzysztof Kozlowski wrote:
>>
>>
>>>> + compatible = "xlnx,zynqmp-uart", "cdns,uart-r1p12";
>>> NAK, you do not have xlnx here. Look at your SoC: name of vendor is
>>> axiado. Not xlnx. How is your SoC called? Also zynqmp? You cannot just
>>> randomly pick any compatibles and stuff them around.
>>>
>>> Please carefully read writing bindings from DT directory.
>>
>> We are using the "cdns,uart-r1p12" for the UART. However, that alone
>> can't be added alone in the compatible as per the DT bindings doc.
> Exactly. See writing bindings... or any guides/talks.
We will add the "compatible = "axiado,ax-uart", "cdns,uart-r1p12". We
will append in the dt-bindings doc and driver.
Is this name look good?
Powered by blists - more mailing lists