linux-kernel - Re: [PATCH v1 1/1] ACPI: LPSS: Remove AudioDSP related ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38ab3fb5-6d1a-491b-ad20-08066b007a28@intel.com>
Date: Thu, 26 Jun 2025 09:54:21 +0200
From: Cezary Rojewski <cezary.rojewski@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
	<linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] ACPI: LPSS: Remove AudioDSP related ID

On 2025-06-25 7:21 PM, Andy Shevchenko wrote:
> The AudioDSP drivers are in control for all functions of the hardware
> they have (they are multi-functional devices). The LPSS driver prepares
> for enumeration only single devices, such as DMA, UART, SPI, I²C. Hence
> the registration of AudioDSP should not be covered. Moreover, the very
> same ACPI _HID has been added by the catpt driver a few years ago.
> 
> And even more serious issue with this, is that the register window at
> offset 0x800 is actually D-SRAM0 in case of AudioDSP and writing to it
> is a data corruption.
> 
> That all being said, remove the AudioDSP ID from the LPSS driver,
> where it doesn't belong to.
> 
> Fixes: fb94b7b11c6a ("ASoC: Intel: Remove SST firmware components")
> Fixes: 05668be1b364 ("ASoC: Intel: Remove SST ACPI component")
> Fixes: 7a10b66a5df9 ("ASoC: Intel: catpt: Device driver lifecycle")

Hi Andy,

A nitpick:

The fixes tags used here seem incorrect. The catpt-driver replaced its 
predecessor (the haswell driver) providing no interface changes. Usage 
of INT3438 ID has been introduced with commit c2f8783fa2d0 ("ASoC: 
Intel: Add common SST driver loader on ACPI systems"), if that's what 
you have been looking for.

In regard to the code - the change has been reviewed by me and tested in 
our CI, no regression on the audio side observed:

Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>
Tested-by: Cezary Rojewski <cezary.rojewski@...el.com>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/acpi/x86/lpss.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/acpi/x86/lpss.c b/drivers/acpi/x86/lpss.c
> index 258440b899a9..6daa6372f980 100644
> --- a/drivers/acpi/x86/lpss.c
> +++ b/drivers/acpi/x86/lpss.c
> @@ -387,9 +387,6 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
>   	{ "INT3435", LPSS_ADDR(lpt_uart_dev_desc) },
>   	{ "INT3436", LPSS_ADDR(lpt_sdio_dev_desc) },
>   
> -	/* Wildcat Point LPSS devices */
> -	{ "INT3438", LPSS_ADDR(lpt_spi_dev_desc) },
> -
>   	{ }
>   };
>