linux-kernel - Re: [PATCH v1 1/1] ACPI: LPSS: Remove AudioDSP related ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aF1J95lLvRFC55NT@smile.fi.intel.com>
Date: Thu, 26 Jun 2025 16:24:07 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Cezary Rojewski <cezary.rojewski@...el.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] ACPI: LPSS: Remove AudioDSP related ID

On Thu, Jun 26, 2025 at 09:54:21AM +0200, Cezary Rojewski wrote:
> On 2025-06-25 7:21 PM, Andy Shevchenko wrote:
> > The AudioDSP drivers are in control for all functions of the hardware
> > they have (they are multi-functional devices). The LPSS driver prepares
> > for enumeration only single devices, such as DMA, UART, SPI, I²C. Hence
> > the registration of AudioDSP should not be covered. Moreover, the very
> > same ACPI _HID has been added by the catpt driver a few years ago.
> > 
> > And even more serious issue with this, is that the register window at
> > offset 0x800 is actually D-SRAM0 in case of AudioDSP and writing to it
> > is a data corruption.
> > 
> > That all being said, remove the AudioDSP ID from the LPSS driver,
> > where it doesn't belong to.
> > 
> > Fixes: fb94b7b11c6a ("ASoC: Intel: Remove SST firmware components")
> > Fixes: 05668be1b364 ("ASoC: Intel: Remove SST ACPI component")
> > Fixes: 7a10b66a5df9 ("ASoC: Intel: catpt: Device driver lifecycle")
> 
> Hi Andy,
> 
> A nitpick:
> 
> The fixes tags used here seem incorrect. The catpt-driver replaced its
> predecessor (the haswell driver) providing no interface changes. Usage of
> INT3438 ID has been introduced with commit c2f8783fa2d0 ("ASoC: Intel: Add
> common SST driver loader on ACPI systems"), if that's what you have been
> looking for.

Okay, thanks for a hint. I will use that in v2.

> In regard to the code - the change has been reviewed by me and tested in our
> CI, no regression on the audio side observed:
> 
> Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>
> Tested-by: Cezary Rojewski <cezary.rojewski@...el.com>

-- 
With Best Regards,
Andy Shevchenko