linux-kernel - RE: [PATCH] wifi: rtl8xxxu: toggle P2P for supported devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0083530d59084b82bebde68a73877568@realtek.com>
Date: Thu, 26 Jun 2025 01:27:40 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Martin Rodriguez Reboredo <yakoyoku@...il.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC: Jes Sorensen <Jes.Sorensen@...il.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] wifi: rtl8xxxu: toggle P2P for supported devices

Martin Rodriguez Reboredo <yakoyoku@...il.com> wrote:
> This is a MR to see if rtl8xxxu can be made to support P2P.

Sorry. What is MR?

> 
> Theoretically this should be handled by mac80211 but it seems that
> drivers may have to take some extra steps depending on which device we
> are talking about. I know that this patch is so basic that it might be
> missing some H2C commands or similar for this to work on Realtek chips
> but I don't have the required knowledge for me to implement it, so if
> you know a place to read about I'll be glad to hear.

The commit message looks informal. Just describe why/what patch does. 
If you want to share more information to readers, add information after
s-o-b with "---". 

Basically if a WiFi device can support station and AP modes, it can
also support P2P mode. To work well, it needs to support additional 
P2P PS, such as NoA, which needs some H2C commands or registers to
achieve. I'm not sure if chips supported by rtl8xxxu have these. 

> 
> As of now only rtl8192ex devices have their P2P_CLIENT and P2P_GO wiphy
> interface modes ensured because those are the only ones I can test on
> my rtl8192eu card. The rest of chips have them set from what I've seen
> in a cursory Internet search, they might or might not work.

Not sure what you really tested (I have seen another thread). Please mention
what you tested in commit message.

> 
> Signed-off-by: Martin Rodriguez Reboredo <yakoyoku@...il.com>

---

(add things you want to share)

> ---
>  drivers/net/wireless/realtek/rtl8xxxu/8188e.c |  1 +
>  drivers/net/wireless/realtek/rtl8xxxu/8188f.c |  1 +
>  drivers/net/wireless/realtek/rtl8xxxu/8192c.c |  1 +
>  drivers/net/wireless/realtek/rtl8xxxu/8192e.c |  1 +
>  drivers/net/wireless/realtek/rtl8xxxu/8192f.c |  1 +
>  drivers/net/wireless/realtek/rtl8xxxu/8710b.c |  1 +
>  drivers/net/wireless/realtek/rtl8xxxu/8723a.c |  1 +
>  drivers/net/wireless/realtek/rtl8xxxu/8723b.c |  1 +
>  drivers/net/wireless/realtek/rtl8xxxu/core.c  | 29 ++++++++++++++++++-
>  .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h  |  1 +
>  10 files changed, 37 insertions(+), 1 deletion(-)
>