linux-kernel - Re: [PATCH] wifi: rtl8xxxu: toggle P2P for supported devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22784267.EfDdHjke4D@tx3000mach.io>
Date: Thu, 26 Jun 2025 17:02:44 -0300
From: Martin Rodriguez Reboredo <yakoyoku@...il.com>
To: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
 Ping-Ke Shih <pkshih@...ltek.com>
Cc: Jes Sorensen <Jes.Sorensen@...il.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wifi: rtl8xxxu: toggle P2P for supported devices

On Wednesday 25 June 2025 22:27:40 Argentina Standard Time Ping-Ke Shih wrote:
> Martin Rodriguez Reboredo <yakoyoku@...il.com> wrote:
>> This is a MR to see if rtl8xxxu can be made to support P2P.
> 
> Sorry. What is MR?

Merge request in GitLab's jargon, like PR.

>> Theoretically this should be handled by mac80211 but it seems that
>> drivers may have to take some extra steps depending on which device we
>> are talking about. I know that this patch is so basic that it might be
>> missing some H2C commands or similar for this to work on Realtek chips
>> but I don't have the required knowledge for me to implement it, so if
>> you know a place to read about I'll be glad to hear.
> 
> The commit message looks informal. Just describe why/what patch does.
> If you want to share more information to readers, add information after
> s-o-b with "---".

I admit that it doesn't look as a proper commit message, I'll take it into 
account in the next version of the patch.

> Basically if a WiFi device can support station and AP modes, it can
> also support P2P mode. To work well, it needs to support additional
> P2P PS, such as NoA, which needs some H2C commands or registers to
> achieve. I'm not sure if chips supported by rtl8xxxu have these.

Many of these chips do have them, per some of the alternative drivers for them 
show in their sources. Perhaps in another patch some methods could be added to 
`rtl8xxxu_fileops`.

> [...]
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)