linux-kernel - Re: [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DAWF24I1XW5Q.3FDHE6CS3DZBB@linaro.org>
Date: Thu, 26 Jun 2025 12:08:56 +0100
From: "Alexey Klimov" <alexey.klimov@...aro.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@....qualcomm.com>,
 <devicetree@...r.kernel.org>, "Jaroslav Kysela" <perex@...ex.cz>,
 <linux-arm-msm@...r.kernel.org>, "Srinivas Kandagatla" <srini@...nel.org>,
 "Takashi Iwai" <tiwai@...e.com>, "Mark Brown" <broonie@...nel.org>,
 <linux-kernel@...r.kernel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Stephen Boyd" <sboyd@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>,
 "Lee Jones" <lee@...nel.org>, <linux-sound@...r.kernel.org>, "Liam
 Girdwood" <lgirdwood@...il.com>, "Dmitry Baryshkov"
 <dmitry.baryshkov@....qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio
 codec

On Thu Jun 26, 2025 at 2:30 AM BST, Rob Herring (Arm) wrote:
>
> On Thu, 26 Jun 2025 00:50:29 +0100, Alexey Klimov wrote:
>> The audio codec IC is found on Qualcomm PM4125/PM2250 PMIC.
>> It has TX and RX soundwire slave devices hence two files
>> are added.
>> 
>> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
>> ---
>>  .../bindings/sound/qcom,pm4125-codec.yaml          | 147 +++++++++++++++++++++
>>  .../devicetree/bindings/sound/qcom,pm4125-sdw.yaml |  86 ++++++++++++
>>  2 files changed, 233 insertions(+)
>> 
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.example.dtb: pmic@0 (qcom,pm8916): audio-codec@...0: 'qcom,micbias1-microvolt', 'qcom,micbias2-microvolt', 'qcom,micbias3-microvolt', 'qcom,rx-device', 'qcom,tx-device', 'vdd-cp-supply', 'vdd-io-supply', 'vdd-mic-bias-supply', 'vdd-pa-vpos-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.example.dtb: pmic@0 (qcom,pm8916): audio-codec@...0:compatible:0: 'qcom,pm8916-wcd-analog-codec' was expected
> 	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250626-pm4125_audio_codec_v1-v1-1-e52933c429a0@linaro.org

The second patch in the series deals with that. Reordering these two patches
doesn't seem to make a lot of sense so I guess squashing it in here is
a way to go.

Thanks,
Alexey