linux-kernel - Re: [PATCH v4 1/2] dt-bindings: i3c: Add adi-i3c-master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41782ded-908b-46ef-8f75-4d2565476b7c@kernel.org>
Date: Fri, 27 Jun 2025 16:49:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jorge Marques <gastmaier@...il.com>
Cc: Jorge Marques <jorge.marques@...log.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Frank Li <Frank.Li@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-i3c@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: i3c: Add adi-i3c-master

On 27/06/2025 16:38, Jorge Marques wrote:
> On Fri, Jun 27, 2025 at 08:56:55AM +0200, Krzysztof Kozlowski wrote:
>> On Thu, Jun 26, 2025 at 12:07:36PM +0200, Jorge Marques wrote:
>>> Add bindings doc for ADI I3C Controller IP core, a FPGA synthesizable IP
>>> core that implements the MIPI I3C Basic controller specification.
>>
>> How did you resolve my last comment? I don't see any explanation -
>> neither here nor in the binding description. Binding description is
>> actually better place, I think now.
>>
>> Best regards,
>> Krzysztof
>>
> 
> Hi Krzysztof,
> 
> I forgot to condense out discussion on v4.
> What about this binding description:
> 
>   description: |
>     FPGA-based I3C controller designed to interface with I3C and I2C
>     peripherals, implementing a subset of the I3C-basic specification.
>     The IP core is tested on arm, microblaze, and arm64 architectures.
>     It takes one or two clocks, axi and i3c. If only axi is provided,
>     then there is no clock signal to the i3c input clock pin and axi

This is obvious from the schema, drop.

>     clock drives the whole IP. The compatible is suffixed by 1.00.a
>     foreseeing future controllers by Analog Devices Inc. and breaking
>     changes.

I don't understand that. How are you breaking any changes? And how
1.00.a predicts future? I don't think this reflects previous discussion.
Why you were asked to go with v1.00.a?

Best regards,
Krzysztof