linux-kernel - RE: [PATCH 1/2] x86/mce: Fix missing address mask in recovery for errors in TDX/SEAM non-root mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB60836014330204B2FBCC7418FC45A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Fri, 27 Jun 2025 16:24:27 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Hansen, Dave" <dave.hansen@...el.com>, "Hunter, Adrian"
	<adrian.hunter@...el.com>
CC: "Annapurve, Vishal" <vannapurve@...gle.com>, Borislav Petkov
	<bp@...en8.de>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
	<mingo@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
	"x86@...nel.org" <x86@...nel.org>, H Peter Anvin <hpa@...or.com>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "Edgecombe, Rick P"
	<rick.p.edgecombe@...el.com>, "kirill.shutemov@...ux.intel.com"
	<kirill.shutemov@...ux.intel.com>, "Huang, Kai" <kai.huang@...el.com>,
	"Chatre, Reinette" <reinette.chatre@...el.com>, "Li, Xiaoyao"
	<xiaoyao.li@...el.com>, "tony.lindgren@...ux.intel.com"
	<tony.lindgren@...ux.intel.com>, "binbin.wu@...ux.intel.com"
	<binbin.wu@...ux.intel.com>, "Yamahata, Isaku" <isaku.yamahata@...el.com>,
	"Zhao, Yan Y" <yan.y.zhao@...el.com>, "Gao, Chao" <chao.gao@...el.com>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>, "seanjc@...gle.com"
	<seanjc@...gle.com>
Subject: RE: [PATCH 1/2] x86/mce: Fix missing address mask in recovery for
 errors in TDX/SEAM non-root mode

>>> Would that mean no one would know if the mce addr had KeyID bits or not?
>
> Uhhh, just store the KeyID separately. Have
>
>	mce->addr
> and
>	mce->keyid
>
> Problem solved.

As the old saying goes: "Solve one problem and create three new ones".

"struct mce" is in user visible in arch/x86/include/uapi/asm/mce.h
(via /dev/mcelog).

So while we can add new fields (at the end of the structure) some thought
about the implications are needed.

We've been sending a combined key+address in the "mce->addr" to
user space for a while. Has anyone built infrastructure on top of that?

-Tony