linux-kernel - Re: [PATCH v3 1/1] spi: spi-cadence-quadspi: Fix pm runtime unbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF5s4f8TOpvDJFyB@finisterre.sirena.org.uk>
Date: Fri, 27 Jun 2025 11:05:21 +0100
From: Mark Brown <broonie@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: khairul.anuar.romli@...era.com,
	"open list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Matthew Gerlach <matthew.gerlach@...era.com>,
	Khairul Anuar Romli <khairulanuar.romli@...era.com>
Subject: Re: [PATCH v3 1/1] spi: spi-cadence-quadspi: Fix pm runtime unbalance

On Fri, Jun 27, 2025 at 07:39:24AM +0300, Dan Carpenter wrote:
> On Thu, Jun 26, 2025 at 11:37:53PM -0500, Dan Carpenter wrote:

> > In other words, if we failed there was some slightly complicated
> > cleanup to do.  But now it will do the cleanup and free things on the
> > success path if we're in cqspi->use_direct_mode.

> I suck at email.  What I meant was delete the if block:

> -	if (cqspi->rx_chan) {
> -		dma_release_channel(cqspi->rx_chan);
> -		goto probe_setup_failed;
> -	}
> -

Can you submit a fix for this please?  The patch is already applied and
in Linus' tree.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)