linux-kernel - RE: [PATCH v3 1/1] spi: spi-cadence-quadspi: Fix pm runtime unbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR03MB50177D7B29E3BF39722B07A6C646A@DM6PR03MB5017.namprd03.prod.outlook.com>
Date: Mon, 30 Jun 2025 09:08:38 +0000
From: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
To: Mark Brown <broonie@...nel.org>, Dan Carpenter <dan.carpenter@...aro.org>
CC: "open list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>, open list
	<linux-kernel@...r.kernel.org>, "Gerlach, Matthew"
	<matthew.gerlach@...era.com>
Subject: RE: [PATCH v3 1/1] spi: spi-cadence-quadspi: Fix pm runtime unbalance

> To: Dan Carpenter <dan.carpenter@...aro.org>
> Cc: Romli, Khairul Anuar <khairul.anuar.romli@...era.com>; open list:SPI
> SUBSYSTEM <linux-spi@...r.kernel.org>; open list <linux-
> kernel@...r.kernel.org>; Gerlach, Matthew <matthew.gerlach@...era.com>;
> Romli, Khairul Anuar <khairul.anuar.romli@...era.com>
> Subject: Re: [PATCH v3 1/1] spi: spi-cadence-quadspi: Fix pm runtime
> unbalance
> 
> On Fri, Jun 27, 2025 at 07:39:24AM +0300, Dan Carpenter wrote:
> > On Thu, Jun 26, 2025 at 11:37:53PM -0500, Dan Carpenter wrote:
> 
> > > In other words, if we failed there was some slightly complicated
> > > cleanup to do.  But now it will do the cleanup and free things on
> > > the success path if we're in cqspi->use_direct_mode.
> 
> > I suck at email.  What I meant was delete the if block:
> 
> > -	if (cqspi->rx_chan) {
> > -		dma_release_channel(cqspi->rx_chan);
> > -		goto probe_setup_failed;
> > -	}
> > -
> 
> Can you submit a fix for this please?  The patch is already applied and in Linus'
> tree.

I'll submit the fix for this.