linux-kernel - Re: [PATCH] i2c: scx200_acb: add depends on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aF5xcWCK_b6pPbGj@shikoro>
Date: Fri, 27 Jun 2025 12:24:49 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...nel.org>,
	Niklas Schnelle <schnelle@...ux.ibm.com>,
	Jim Cromie <jim.cromie@...il.com>,
	Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: scx200_acb: add depends on HAS_IOPORT

On Fri, Jun 27, 2025 at 12:18:33PM +0200, Wolfram Sang wrote:
> On Sun, Jun 15, 2025 at 11:36:58AM -0700, Randy Dunlap wrote:
> > The scx200_acb driver uses inb()/outb() without depending on HAS_IOPORT,
> > which leads to build errors since kernel v6.13-rc1:
> > commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
> > for HAS_IOPORT=n")
> > 
> > Add the HAS_IOPORT dependency to prevent the build errors.
> > 
> > (Found in ARCH=um allmodconfig builds)
> > 
> > drivers/i2c/busses/scx200_acb.c: In function ‘scx200_acb_reset’:
> > include/asm-generic/io.h:596:15: error: call to ‘_outb’ declared with attribute error: outb() requires CONFIG_HAS_IOPORT
> > 
> > drivers/i2c/busses/scx200_acb.c:224:26: note: in expansion of macro ‘inb’
> > include/asm-generic/io.h:542:14: error: call to ‘_inb’ declared with attribute error: inb()) requires CONFIG_HAS_IOPORT
> >   224 |                 status = inb(ACBST);
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Arnd Bergmann <arnd@...nel.org>
> > Cc: Niklas Schnelle <schnelle@...ux.ibm.com>
> > Cc: Jim Cromie <jim.cromie@...il.com>
> > Cc: Andi Shyti <andi.shyti@...nel.org>
> > Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>
> > Cc: linux-i2c@...r.kernel.org
> 
> Applied to for-current, thanks!

Ah, sorry, I already applied an earlier patch...