linux-kernel - Re: [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6151f833d5a06369cd3dce5d2b2aca9f@disroot.org>
Date: Sat, 28 Jun 2025 07:19:32 +0000
From: Kaustabh Chakraborty <kauschluss@...root.org>
To: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, Krzysztof
 Kozlowski <krzk@...nel.org>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow
 mipi-phy subnode

On 2025-06-27 21:42, Rob Herring wrote:
> On Fri, Jun 27, 2025 at 01:43:25AM +0530, Kaustabh Chakraborty wrote:
>> Add Exynos7870's PMU compatible to the list of nodes which allow a 
>> MIPI
>> PHY driver.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@...root.org>
>> ---
>>  Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml 
>> b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>> index 
>> f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 
>> 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>> @@ -172,6 +172,7 @@ allOf:
>>                - samsung,exynos5250-pmu
>>                - samsung,exynos5420-pmu
>>                - samsung,exynos5433-pmu
>> +              - samsung,exynos7870-pmu
> 
> Don't you need to add this to 'compatible' and under 'select'?

compatible: [1]

samsung,exynos7-pmu is under select. 7870 has a fallback on 7.
Do you think samsung,exynos7-pmu should've been added in this patch
instead?

[1] 
https://elixir.bootlin.com/linux/v6.16-rc3/source/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml#L56

> 
>>      then:
>>        properties:
>>          mipi-phy: true
>> 
>> --
>> 2.49.0
>>