linux-kernel - Re: [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfe59771-f35d-48b7-aed3-7b6f3ef1f1dd@kernel.org>
Date: Sat, 28 Jun 2025 11:33:05 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kaustabh Chakraborty <kauschluss@...root.org>,
 Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow
 mipi-phy subnode

On 28/06/2025 09:19, Kaustabh Chakraborty wrote:
>>> diff --git 
>>> a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml 
>>> b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>>> index 
>>> f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 
>>> 100644
>>> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>>> @@ -172,6 +172,7 @@ allOf:
>>>                - samsung,exynos5250-pmu
>>>                - samsung,exynos5420-pmu
>>>                - samsung,exynos5433-pmu
>>> +              - samsung,exynos7870-pmu
>>
>> Don't you need to add this to 'compatible' and under 'select'?
> 
> compatible: [1]
> 
> samsung,exynos7-pmu is under select. 7870 has a fallback on 7.
> Do you think samsung,exynos7-pmu should've been added in this patch
> instead?
> 
If this uses exynos7-pmu as fallback then it is fine. This should be in
commit msg - that's the point of commit msg - explain the hardware and
things not easily visible, instead of repeating what is visible in the diff.

Best regards,
Krzysztof