linux-kernel - Re: [PATCH] Introduce Tyr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mgt4ZD43Tm2bFr-gpicXMhFbC2DLqA6F0rN_J4rAe_CQ@mail.gmail.com>
Date: Sat, 28 Jun 2025 11:31:21 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Daniel Almeida <daniel.almeida@...labora.com>
Cc: Danilo Krummrich <dakr@...nel.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Daniel Stone <daniels@...labora.com>, Rob Herring <robh@...nel.org>, 
	Alice Ryhl <alice.ryhl@...gle.com>, Beata Michalska <beata.michalska@....com>, 
	Carsten Haitzler <carsten.haitzler@...s.arm.com>, 
	Boris Brezillon <boris.brezillon@...labora.com>, Ashley Smith <ashley.smith@...labora.com>, 
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	rust-for-linux@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH] Introduce Tyr

On Sat, Jun 28, 2025 at 2:13 AM Daniel Almeida
<daniel.almeida@...labora.com> wrote:
>
> Also, for some reason the Clippy lint did not save me this time.

Hmm... it should -- I tried to build it and Clippy reports it. There
is also another warning too [1].

I see the compiler reporting [2] too.

By the way, do you need to depend on `CONFIG_REGULATOR`?

Thanks!

Cheers,
Miguel

[1]

error: this operation has no effect
   --> drivers/gpu/drm/tyr/regs.rs:221:16
    |
221 |     (3 << 2) | ((w as u32) << 0) | ((r as u32) << 1)
    |                ^^^^^^^^^^^^^^^^^ help: consider reducing it to:
`((w as u32))`

[2]

error: variable does not need to be mutable
   --> rust/kernel/regulator.rs:295:29
    |
295 |     pub fn try_into_enabled(mut self) ->
Result<Regulator<Enabled>, Error<Disabled>> {
    |                             ----^^^^

error: variable does not need to be mutable
   --> rust/kernel/regulator.rs:324:30
    |
324 |     pub fn try_into_disabled(mut self) ->
Result<Regulator<Disabled>, Error<Enabled>> {
    |                              ----^^^^