linux-kernel - Re: [PATCH v2] selftests: futex: define SYS_futex on 32-bit architectures with 64-bit time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b5231e2-8dd0-4bbf-a0d3-0f6460bc8030@collabora.com>
Date: Sat, 28 Jun 2025 14:28:42 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Ben Zong-You Xie <ben717@...estech.com>
Cc: tglx@...utronix.de, mingo@...hat.com, peterz@...radead.org,
 dvhart@...radead.org, dave@...olabs.net, andrealmeid@...lia.com,
 shuah@...nel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, tim609@...estech.com,
 Cynthia Huang <cynthia@...estech.com>
Subject: Re: [PATCH v2] selftests: futex: define SYS_futex on 32-bit
 architectures with 64-bit time_t

On 6/27/25 2:08 PM, Ben Zong-You Xie wrote:
> glibc does not define SYS_futex for 32-bit architectures using 64-bit
> time_t e.g. riscv32, therefore this test fails to compile since it does not
> find SYS_futex in C library headers. Define SYS_futex as SYS_futex_time64
> in this situation to ensure successful compilation and compatibility.
> 
> Signed-off-by: Cynthia Huang <cynthia@...estech.com>
> Signed-off-by: Ben Zong-You Xie <ben717@...estech.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
> Changes since v1:
>   - Fix the SOB chain
> 
> v1 : https://lore.kernel.org/all/20250527093536.3646143-1-ben717@andestech.com/
> ---
>  tools/testing/selftests/futex/include/futextest.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tools/testing/selftests/futex/include/futextest.h b/tools/testing/selftests/futex/include/futextest.h
> index ddbcfc9b7bac..7a5fd1d5355e 100644
> --- a/tools/testing/selftests/futex/include/futextest.h
> +++ b/tools/testing/selftests/futex/include/futextest.h
> @@ -47,6 +47,17 @@ typedef volatile u_int32_t futex_t;
>  					 FUTEX_PRIVATE_FLAG)
>  #endif
> 
> +/*
> + * SYS_futex is expected from system C library, in glibc some 32-bit
> + * architectures (e.g. RV32) are using 64-bit time_t, therefore it doesn't have
> + * SYS_futex defined but just SYS_futex_time64. Define SYS_futex as
> + * SYS_futex_time64 in this situation to ensure the compilation and the
> + * compatibility.
> + */
> +#if !defined(SYS_futex) && defined(SYS_futex_time64)
> +#define SYS_futex SYS_futex_time64
> +#endif
> +
>  /**
>   * futex() - SYS_futex syscall wrapper
>   * @uaddr:	address of first futex
> --
> 2.34.1