[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DAY60NP32ZDA.155XFXZ9AOF70@kernel.org>
Date: Sat, 28 Jun 2025 14:29:11 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: <j@...nau.net>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
<alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
<gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
"Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
"Danilo Krummrich" <dakr@...nel.org>, "Fiona Behrens" <me@...enk.dev>
Cc: <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust: init: Fix generics in *_init! macros
On Sat Jun 28, 2025 at 1:36 PM CEST, Janne Grunau via B4 Relay wrote:
> From: Janne Grunau <j@...nau.net>
>
> The match pattern for a optional trailing comma in the list of generics
> is erroneously repeated in the code block resulting in following error:
>
> | error: attempted to repeat an expression containing no syntax variables matched as repeating at this depth
> | --> rust/kernel/init.rs:301:73
> | |
> | 301 | ::pin_init::try_pin_init!($(&$this in)? $t $(::<$($generics),* $(,)?>)? {
> | | ^^^
>
> Remove "$(,)?" from all code blocks in the try_init! and try_pin_init!
> definitions.
Oops, that's a good catch! Seems like nobody used the generics before...
Do you need this to go in as a fix into v6.16, or is it fine if I pick
it for v6.17, since it's only a build failure?
@Miguel any opinion?
---
Cheers,
Benno
> Fixes: 578eb8b6db13 ("rust: pin-init: move the default error behavior of `try_[pin_]init`")
> Signed-off-by: Janne Grunau <j@...nau.net>
> ---
> rust/kernel/init.rs | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Powered by blists - more mailing lists