linux-kernel - Re: [PATCH v13 1/7] mfd: Add core driver for Nuvoton NCT6694

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76f34610-6792-4be6-a5d6-622fba7d85da@web.de>
Date: Sat, 28 Jun 2025 14:30:14 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Ming Yu <a0282524688@...il.com>, linux-can@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-rtc@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-watchdog@...r.kernel.org,
 netdev@...r.kernel.org, Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Andi Shyti <andi.shyti@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 Bartosz Golaszewski <brgl@...ev.pl>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Günter Röck <linux@...ck-us.net>,
 Jakub Kicinski <kuba@...nel.org>, Jean Delvare <jdelvare@...e.com>,
 Lee Jones <lee@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Marc Kleine-Budde <mkl@...gutronix.de>, Paolo Abeni <pabeni@...hat.com>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc: Ming Yu <tmyu0@...oton.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v13 1/7] mfd: Add core driver for Nuvoton NCT6694

…
> +++ b/drivers/mfd/nct6694.c
> @@ -0,0 +1,390 @@
…
> static void nct6694_irq_enable(struct irq_data *data)
> +{
…
> +	spin_lock_irqsave(&nct6694->irq_lock, flags);
> +	nct6694->irq_enable |= BIT(hwirq);
> +	spin_unlock_irqrestore(&nct6694->irq_lock, flags);
> +}
…

Will development interests grow to apply a statement
like “guard(spinlock_irqsave)(&nct6694->irq_lock);”?
https://elixir.bootlin.com/linux/v6.16-rc3/source/include/linux/spinlock.h#L585-L588

Regards,
Markus