linux-kernel - Re: [PATCH v13 5/5] serial: sh-sci: Add support for RZ/T2H SCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025062914-unkempt-reentry-470c@gregkh>
Date: Sun, 29 Jun 2025 14:27:09 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	Biju Das <biju.das.jz@...renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v13 5/5] serial: sh-sci: Add support for RZ/T2H SCI

On Sat, Jun 28, 2025 at 12:57:15PM +0100, Prabhakar wrote:
> +EXPORT_SYMBOL(sci_port_enable);

EXPORT_SYMBOL_GPL() perhaps?  (sorry, I have to ask).

Also, why not limit this to just this one other driver that you want to
use it with the proper namespace usage instead?

Same for all other new exports in this file.

thanks,

greg k-h