linux-kernel - Re: [PATCH v7] staging: media: atomisp: code style cleanup series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfoJ17a=3P3fXHa2mN00S+hdz-vRtLfjmsT7-+i2NfWEw@mail.gmail.com>
Date: Sun, 29 Jun 2025 22:11:07 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Hans de Goede <hansg@...nel.org>
Cc: LiangCheng Wang <zaq14760@...il.com>, mchehab@...nel.org, sakari.ailus@...ux.intel.com, 
	andy@...nel.org, gregkh@...uxfoundation.org, nathan@...nel.org, 
	nick.desaulniers+lkml@...il.com, morbo@...gle.com, justinstitt@...gle.com, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-staging@...ts.linux.dev, llvm@...ts.linux.dev
Subject: Re: [PATCH v7] staging: media: atomisp: code style cleanup series

On Sun, Jun 29, 2025 at 3:20 PM Hans de Goede <hansg@...nel.org> wrote:
> On 29-Jun-25 1:30 PM, LiangCheng Wang wrote:

...

> > Changes in v7:
> > - Split previous monolithic patch into multiple smaller patches
> > - Applied clang-format to entire driver excluding i2c directory
>
> I took a quick look at just the clang-format patch and looking
> at the bits of the diff which were not collapsed by github because
> the changes are too big, it looks like the changes which clang-format
> makes are useless and often make things worse, e.g. just looking
> at the first diff which github shows for:
>
> https://github.com/lc-wang/linux/commit/8a3bbdba275e42dfcb0af2ddcc2f27463bb316d2
>
> which is for drivers/staging/media/atomisp/include/hmm/hmm.h
> then all of the changes are undesirable and unneeded.
>
> so the running of clang-format just seems to make things worse.
>
> I appreciate coding-style cleanups outside of the i2c dir,
> but it looks like you need to do everything manually since
> clang-format is just making a mess of things.

Yeah, that what I was afraid of. I don't know clang-format well
enough, but it might be that tweaking existing .clang-format in the
kernel can give something better.

> Also if you do manual code-style cleanups please do one
> type of cleanup per patches, e.g. only fix indentation
> using spaces instead of tabs and do so on groups of say
> 10 files at a time to keep things reviewable.

-- 
With Best Regards,
Andy Shevchenko