linux-kernel - Re: [PATCH v7] staging: media: atomisp: code style cleanup series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcPzq9XrFD29+uZ1rbFcDxb4UbXNkv_QZ=3iyVm3dxyPg@mail.gmail.com>
Date: Sun, 29 Jun 2025 22:14:38 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: 王良丞 <zaq14760@...il.com>
Cc: Hans de Goede <hansg@...nel.org>, mchehab@...nel.org, sakari.ailus@...ux.intel.com, 
	andy@...nel.org, gregkh@...uxfoundation.org, nathan@...nel.org, 
	nick.desaulniers+lkml@...il.com, morbo@...gle.com, justinstitt@...gle.com, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-staging@...ts.linux.dev, llvm@...ts.linux.dev
Subject: Re: [PATCH v7] staging: media: atomisp: code style cleanup series

On Sun, Jun 29, 2025 at 4:02 PM 王良丞 <zaq14760@...il.com> wrote:
>
> Dear Hans and Andy,

First of all, please stop top-posting!

> Thanks for the feedback. I'll wait for Andy's opinion on this before
> taking further actions.

TBH I don't know what I can help with or should do. I expressed my
worries already in one of the previous emails where I suggested to
check clang-format and then when we see the first attempt of using it.

> Meanwhile, I understand Hans' concerns about clang-format changes and
> I can prepare manual cleanup patches as suggested if needed.

Or you can try (without sending each time the result) amending output
of clang-format, or you can do a set of scripts based on the problems
found... Take your time and experiment more, no need to send a new
version every couple of days or so.

> > On 29-Jun-25 1:30 PM, LiangCheng Wang wrote:
> > > This series applies clang-format and fixes all checkpatch.pl-reported ERRORs in the AtomISP driver, excluding the i2c directory as advised by maintainers.
> > >
> > > The changes include:
> > > - Applying clang-format (excluding drivers/staging/media/i2c)
> > > - Removing unnecessary parentheses in return statements
> > > - Removing unnecessary zero-initialized globals
> > > - Fixing space issues after unary minus operators
> > > - Wrapping complex macro values in parentheses
> > > - These patches focus solely on mechanical style cleanups with no functional changes.
> > > - WARNINGs reported by checkpatch.pl were intentionally left for future work to keep each patch clear and manageable.
> > >
> > > The full series and corresponding commits are also available in my public Git repository:
> > >
> > > https://github.com/lc-wang/linux/tree/b4/atomisp

> > > Changes in v7:
> > > - Split previous monolithic patch into multiple smaller patches
> > > - Applied clang-format to entire driver excluding i2c directory
> >
> > I took a quick look at just the clang-format patch and looking
> > at the bits of the diff which were not collapsed by github because
> > the changes are too big, it looks like the changes which clang-format
> > makes are useless and often make things worse, e.g. just looking
> > at the first diff which github shows for:
> >
> > https://github.com/lc-wang/linux/commit/8a3bbdba275e42dfcb0af2ddcc2f27463bb316d2
> >
> > which is for drivers/staging/media/atomisp/include/hmm/hmm.h
> > then all of the changes are undesirable and unneeded.
> >
> > so the running of clang-format just seems to make things worse.
> >
> > I appreciate coding-style cleanups outside of the i2c dir,
> > but it looks like you need to do everything manually since
> > clang-format is just making a mess of things.
> >
> > Also if you do manual code-style cleanups please do one
> > type of cleanup per patches, e.g. only fix indentation
> > using spaces instead of tabs and do so on groups of say
> > 10 files at a time to keep things reviewable.

-- 
With Best Regards,
Andy Shevchenko