linux-kernel - Re: [PATCH v3 1/4] spi: dt-bindings: spi-sg2044-nor: Change SOPHGO SG2042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175118936320.3838715.11903647701453583408.robh@kernel.org>
Date: Sun, 29 Jun 2025 04:29:23 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Zixian Zeng <sycamoremoon376@...il.com>
Cc: Paul Walmsley <paul.walmsley@...ive.com>, 
 Tudor Ambarus <tudor.ambarus@...aro.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, sophgo@...ts.linux.dev, 
 Palmer Dabbelt <palmer@...belt.com>, Mark Brown <broonie@...nel.org>, 
 Chen Wang <unicorn_wang@...look.com>, linux-mtd@...ts.infradead.org, 
 Miquel Raynal <miquel.raynal@...tlin.com>, linux-riscv@...ts.infradead.org, 
 Conor Dooley <conor+dt@...nel.org>, Pratyush Yadav <pratyush@...nel.org>, 
 linux-spi@...r.kernel.org, devicetree@...r.kernel.org, 
 Michael Walle <mwalle@...nel.org>, Richard Weinberger <richard@....at>, 
 Albert Ou <aou@...s.berkeley.edu>, Inochi Amaoto <inochiama@...il.com>, 
 Alexandre Ghiti <alex@...ti.fr>, Longbin Li <looong.bin@...il.com>, 
 Vignesh Raghavendra <vigneshr@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] spi: dt-bindings: spi-sg2044-nor: Change SOPHGO
 SG2042


On Sun, 29 Jun 2025 16:23:10 +0800, Zixian Zeng wrote:
> SG2042 is not fully compatiable with SG2044,
> So it is necessary to become independent const
> 
> Signed-off-by: Zixian Zeng <sycamoremoon376@...il.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-sg2044-nor.yaml | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/spi-sg2044-nor.yaml: properties:compatible:oneOf: [{'const': 'sophgo,sg2044-spifmc-nor'}, {'const': 'sophgo,sg2042-spifmc-nor'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}}
	hint: Use 'enum' rather than 'oneOf' + 'const' entries
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250629-sfg-spifmc-v3-1-28db1f27e999@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.