linux-kernel - Re: [PATCH resend] rtc: Rename lib_test to rtc_lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250630135427faa6c326@mail.local>
Date: Mon, 30 Jun 2025 15:54:27 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>,
	David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>,
	linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com
Subject: Re: [PATCH resend] rtc: Rename lib_test to rtc_lib_test

On 30/06/2025 09:47:54+0200, Geert Uytterhoeven wrote:
> When compiling the RTC library functions test as a module, the module
> has the non-descriptive name "lib_test.ko".  Fix this by adding the
> subsystem's name as a prefix.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/rtc/Makefile                       | 2 +-
>  drivers/rtc/{lib_test.c => rtc_lib_test.c} | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename drivers/rtc/{lib_test.c => rtc_lib_test.c} (100%)
> 
> diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
> index 4619aa2ac4697591..aa08d1c8a32ec23d 100644
> --- a/drivers/rtc/Makefile
> +++ b/drivers/rtc/Makefile
> @@ -15,7 +15,7 @@ rtc-core-$(CONFIG_RTC_INTF_DEV)		+= dev.o
>  rtc-core-$(CONFIG_RTC_INTF_PROC)	+= proc.o
>  rtc-core-$(CONFIG_RTC_INTF_SYSFS)	+= sysfs.o
>  
> -obj-$(CONFIG_RTC_LIB_KUNIT_TEST)	+= lib_test.o
> +obj-$(CONFIG_RTC_LIB_KUNIT_TEST)	+= rtc_lib_test.o

I'd rather have test_rtc_lib as only the drivers are currently prefixed with
rtc.

>  
>  # Keep the list ordered.
>  
> diff --git a/drivers/rtc/lib_test.c b/drivers/rtc/rtc_lib_test.c
> similarity index 100%
> rename from drivers/rtc/lib_test.c
> rename to drivers/rtc/rtc_lib_test.c
> -- 
> 2.43.0
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com