linux-kernel - Re: [PATCH resend] rtc: Rename lib_test to rtc_lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVPDVXXYH5OJyZ0dfbU0YLfc4sUGR=o=vu1PmWGne3dZw@mail.gmail.com>
Date: Tue, 1 Jul 2025 09:45:45 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	Rae Moar <rmoar@...gle.com>, linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com
Subject: Re: [PATCH resend] rtc: Rename lib_test to rtc_lib_test

Hi Alex.

On Mon, 30 Jun 2025 at 15:54, Alexandre Belloni
<alexandre.belloni@...tlin.com> wrote:
> On 30/06/2025 09:47:54+0200, Geert Uytterhoeven wrote:
> > When compiling the RTC library functions test as a module, the module
> > has the non-descriptive name "lib_test.ko".  Fix this by adding the
> > subsystem's name as a prefix.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > ---
> >  drivers/rtc/Makefile                       | 2 +-
> >  drivers/rtc/{lib_test.c => rtc_lib_test.c} | 0
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >  rename drivers/rtc/{lib_test.c => rtc_lib_test.c} (100%)
> >
> > diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
> > index 4619aa2ac4697591..aa08d1c8a32ec23d 100644
> > --- a/drivers/rtc/Makefile
> > +++ b/drivers/rtc/Makefile
> > @@ -15,7 +15,7 @@ rtc-core-$(CONFIG_RTC_INTF_DEV)             += dev.o
> >  rtc-core-$(CONFIG_RTC_INTF_PROC)     += proc.o
> >  rtc-core-$(CONFIG_RTC_INTF_SYSFS)    += sysfs.o
> >
> > -obj-$(CONFIG_RTC_LIB_KUNIT_TEST)     += lib_test.o
> > +obj-$(CONFIG_RTC_LIB_KUNIT_TEST)     += rtc_lib_test.o
>
> I'd rather have test_rtc_lib as only the drivers are currently prefixed with
> rtc.

Your wish is my command; v2 sent.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds