linux-kernel - Re: [PATCH net-next v1 2/2] selftests: pp-bench: remove page_pool_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC_iWjLY10NAW7b7-vk5UD3x-Nay=4sfAW5uowq2MKyK_h-6aQ@mail.gmail.com>
Date: Mon, 30 Jun 2025 18:00:55 +0300
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Simon Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>, 
	Toke Høiland-Jørgensen <toke@...hat.com>, 
	Jesper Dangaard Brouer <hawk@...nel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next v1 2/2] selftests: pp-bench: remove
 page_pool_put_page wrapper

On Fri, 27 Jun 2025 at 23:05, Mina Almasry <almasrymina@...gle.com> wrote:
>
> Minor cleanup: remove the pointless looking _ wrapper around
> page_pool_put_page, and just do the call directly.
>
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>

> ---
>  .../net/bench/page_pool/bench_page_pool_simple.c     | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c b/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c
> index 1cd3157fb6a9..cb6468adbda4 100644
> --- a/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c
> +++ b/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c
> @@ -16,12 +16,6 @@
>  static int verbose = 1;
>  #define MY_POOL_SIZE 1024
>
> -static void _page_pool_put_page(struct page_pool *pool, struct page *page,
> -                               bool allow_direct)
> -{
> -       page_pool_put_page(pool, page, -1, allow_direct);
> -}
> -
>  /* Makes tests selectable. Useful for perf-record to analyze a single test.
>   * Hint: Bash shells support writing binary number like: $((2#101010)
>   *
> @@ -121,7 +115,7 @@ static void pp_fill_ptr_ring(struct page_pool *pp, int elems)
>         for (i = 0; i < elems; i++)
>                 array[i] = page_pool_alloc_pages(pp, gfp_mask);
>         for (i = 0; i < elems; i++)
> -               _page_pool_put_page(pp, array[i], false);
> +               page_pool_put_page(pp, array[i], -1, false);
>
>         kfree(array);
>  }
> @@ -180,14 +174,14 @@ static int time_bench_page_pool(struct time_bench_record *rec, void *data,
>
>                 } else if (type == type_ptr_ring) {
>                         /* Normal return path */
> -                       _page_pool_put_page(pp, page, false);
> +                       page_pool_put_page(pp, page, -1, false);
>
>                 } else if (type == type_page_allocator) {
>                         /* Test if not pages are recycled, but instead
>                          * returned back into systems page allocator
>                          */
>                         get_page(page); /* cause no-recycling */
> -                       _page_pool_put_page(pp, page, false);
> +                       page_pool_put_page(pp, page, -1, false);
>                         put_page(page);
>                 } else {
>                         BUILD_BUG();
> --
> 2.50.0.727.gbf7dc18ff4-goog
>