linux-kernel - Re: [PATCH] HID: playstation: DS4: Add BT poll interval adjustment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e33f4cec-dec5-41ae-a1dd-aa6953604526@gmail.com>
Date: Mon, 30 Jun 2025 16:59:26 +0200
From: Vadym Tytan <titanv3585@...il.com>
To: Terry Junge <linuxhid@...micgizmosystems.com>,
 kernel test robot <lkp@...el.com>,
 Roderick Colenbrander <roderick.colenbrander@...y.com>,
 Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
 linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH] HID: playstation: DS4: Add BT poll interval adjustment

> Should it be      .attr    = { .name = "dualshock4_bt_poll_interval", .mode = 0644 },  ?
> 
> Or did you not expand the macro fully on purpose?
> 
> Thanks,
> Terry

Here's my own quote

> P.S. Macro was expanded and variable name was changed from `dev_attr_bt_poll_interval` to `dev_attr_dualshock4_bt_poll_interval` because this attribute only applies to DualShock4
So, yes, i expanded it like that on purpose, as it applies only to DS4, 
and while being attribute, it applies only per device, so no collision 
is possible.

You're welcome
Vadym