Message-ID: <CAK7LNARnYi7-aL1NYj3s5udeBMjNEurHx0cDwbU14Uks6FXa9Q@mail.gmail.com>
Date: Tue, 1 Jul 2025 00:48:50 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/66] kconfig: improve xconfig and gconfig

On Mon, Jun 30, 2025 at 3:55 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
>
>
> On 6/24/25 8:04 AM, Masahiro Yamada wrote:
> > [xconfig]
> >
> >  - small improvement for choice
> >
> > [gconfig]
> >
> >  - Fix memory leak
> >  - Lots of refactoring
> >  - Migrate GTK 2 to GTK 3
> >  - Fix all compile warnings
> >  - Improve usability (grey out buttons, keep the item selection, etc.)
> >
> >
>
> Hi,
> I have tested all 65 patches here (omitting 52).
> They worked well. Good job.
> I will test your git tree/branch Monday/Tuesday.
>
> I did notice one visual difference. The GTK+2 version of
> gconfig (before the patches) uses an alternating white/light gray
> background for the menu items while the GTK+3 version (after the
> patches) uses an all white background.
>
> I prefer the alternating but it may be just some collateral damage
> in the name of progress.  Or could be something else entirely!


I think
[PATCH 15/66] kconfig: gconf: remove gtk_tree_view_set_rules_hint() calls
affected this.

gtk_tree_view_set_rules_hint() is deprecated.


The comment says "just do it in a theme"
 https://gitlab.gnome.org/GNOME/gtk/-/blob/3.14.0/gtk/gtktreeview.c#L11875

But, I do not know which theme should be applied.




> Before you posted all of these gconfig patches, I was going to ask
> how many gconfig users are there?  I don't see much on the mailing
> list about gconfig from users and suggest that maybe we should just
> drop it, but if you are OK with maintaining it and updating it like
> in this patch series, so be it.
>
> I did seem to have found one gconfig user [1]. Maybe you are also
> a gconfig user.

I keep it as far as I can maintain it.
I am not a heavy user of gconfig, but I maintain all front-ends for now.


>
>
> [1] https://lore.kernel.org/linux-kbuild/67b44d49-d23c-fab0-e165-cc84817562af@infradead.org/
>
>
>
> >
> > Masahiro Yamada (66):
> >   kconfig: set MENU_CHANGED to choice when the selected member is
> >     changed
> >   kconfig: qconf: do not show checkbox icon for choice
> >   kconfig: qconf: show selected choice in the Value column
> >   kconfig: rename menu_get_parent_menu() to
> >     menu_get_menu_or_parent_menu()
> >   kconfig: re-add menu_get_parent_menu() that returns parent menu
> >   kconfig: gconf: make columns resizable
> >   kconfig: gconf: fix potential memory leak in renderer_edited()
> >   kconfig: gconf: always destroy dialog in on_window1_delete_event()
> >   kconfig: gconf: remove old #ifdef GTK_CHECK_VERSION
> >   kconfig: gconf: remove empty if-block
> >   kconfig: gconf: remove meaningless code in init_main_window()
> >   kconfig: gconf: remove unneeded gtk_tree_view_set_headers_visible()
> >     calls
> >   kconfig: gconf: remove gtk_tree_view_column_set_visible() calls
> >   kconfig: gconf: remove gtk_widget_realize() calls
> >   kconfig: gconf: remove gtk_tree_view_set_rules_hint() calls
> >   kconfig: gconf: remove unnecessary gtk_set_locale() call
> >   kconfig: gconf: remove internal-child="image" nodes from glade
> >   kconfig: gconf: remove parents[] array and indent variable
> >   kconfig: gconf: remove unnecessary NULL checks for tree1 and tree2
> >   kconfig: gconf: remove unneeded variable in on_split_clicked()
> >   kconfig: gconf: remove unneeded variables in
> >     on_treeview*_button_press_event()
> >   kconfig: gconf: remove unused 'color' variable
> >   kconfig: gconf: add static qualifiers to variables
> >   kconfig: gconf: move init_*() functions below
> >   kconfig: gconf: refactor view setting code
> >   kconfig: gconf: grey out button for current view
> >   kconfig: gconf: move the main window event handlers below
> >   kconfig: gconf: move button1 initialization below
> >   kconfig: gconf: add static qualifiers to event handlers
> >   kconfig: gconf: remove glade_xml_signal_autoconnect() call
> >   kconfig: gconf: make key_press_event work in left pane too
> >   kconfig: gconf: avoid hardcoding model2 in
> >     on_treeview2_cursor_changed()
> >   kconfig: gconf: avoid hardcoding model2 in renderer_edited()
> >   kconfig: gconf: avoid hardcoding model* in
> >     on_treeview*_button_press_event()
> >   kconfig: gconf: add on_save_clicked() event handler
> >   kconfig: gconf: use GtkFileChooser in on_load1_activate()
> >   kconfig: gconf: use GtkFileChooser in on_save_as1_activate()
> >   kconfig: gconf: use GdkPixbuf in replace_button_icon()
> >   kconfig: gconf: refactor replace_button_icon()
> >   kconfig: gconf: make introduction, about, license dialogs modal
> >   kconfig: gconf: remove global 'tree' variable
> >   kconfig: gconf: merge 'current' and 'browsed' global variables
> >   kconfig: gconf: preserve menu selection when switching view mode
> >   kconfig: gconf: use GtkTreeModelFilter to control row visibility
> >   kconfig: gconf: remove global 'model1' and 'model2' variables
> >   kconfig: gconf: remove init_tree_model()
> >   kconfig: gconf: inline fill_row() into set_node()
> >   kconfig: gconf: do not reconstruct tree store when a symbol is changed
> >   kconfig: gconf: inline display_list() into set_view_mode()
> >   kconfig: gconf: remove dead code in display_tree_part()
> >   kconfig: gconf: rename display_tree_part()
> >   kconfig: gconf: remove fixup_rootmenu()
> >   kconfig: gconf: use size_allocate event handler
> >   kconfig: gconf: replace GDK_space with GDK_KEY_space
> >   kconfig: gconf: replace GTK_STOCK_{OK,NO,CANCEL}
> >   kconfig: gconf: remove "tooltips" property from glade
> >   kconfig: gconf: replace "tooltip" property with "tooltip-text"
> >   kconfig: gconf: remove unnecessary default message in text view
> >   kconfig: gconf: use gtk_check_menu_item_get_active() accessor
> >   kconfig: gconf: use gtk_dialog_get_content_area() accessor
> >   kconfig: gconf: remove GtkHandleBox from glade
> >   kconfig: gconf: rename gconf.glade to gconf.ui
> >   kconfig: gconf: migrate to GTK 3
> >   kconfig: gconf: replace GtkVbox with GtkBox
> >   kconfig: gconf: replace GdkColor with GdkRGBA
> >   kconfig: gconf: show GTK version in About dialog
> >
> >  scripts/kconfig/conf.c                    |    2 +-
> >  scripts/kconfig/gconf-cfg.sh              |   11 +-
> >  scripts/kconfig/gconf.c                   | 1828 ++++++++++-----------
> >  scripts/kconfig/{gconf.glade => gconf.ui} |  360 ++--
> >  scripts/kconfig/lkc.h                     |    1 +
> >  scripts/kconfig/menu.c                    |   20 +
> >  scripts/kconfig/qconf.cc                  |   26 +-
> >  scripts/kconfig/symbol.c                  |    4 +
> >  8 files changed, 1023 insertions(+), 1229 deletions(-)
> >  rename scripts/kconfig/{gconf.glade => gconf.ui} (57%)
> >
>
> --
> ~Randy
>


-- 
Best Regards
Masahiro Yamada

Powered by blists - more mailing lists