linux-kernel - Re: [PATCH 00/66] kconfig: improve xconfig and gconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52563c74-9644-4616-ab95-f899f1c881f5@infradead.org>
Date: Mon, 30 Jun 2025 16:43:31 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/66] kconfig: improve xconfig and gconfig



On 6/30/25 8:48 AM, Masahiro Yamada wrote:
> On Mon, Jun 30, 2025 at 3:55 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>>
>>
>>
>> On 6/24/25 8:04 AM, Masahiro Yamada wrote:
>>> [xconfig]
>>>
>>>  - small improvement for choice
>>>
>>> [gconfig]
>>>
>>>  - Fix memory leak
>>>  - Lots of refactoring
>>>  - Migrate GTK 2 to GTK 3
>>>  - Fix all compile warnings
>>>  - Improve usability (grey out buttons, keep the item selection, etc.)
>>>
>>>
>>
>> Hi,
>> I have tested all 65 patches here (omitting 52).
>> They worked well. Good job.
>> I will test your git tree/branch Monday/Tuesday.
>>
>> I did notice one visual difference. The GTK+2 version of
>> gconfig (before the patches) uses an alternating white/light gray
>> background for the menu items while the GTK+3 version (after the
>> patches) uses an all white background.
>>
>> I prefer the alternating but it may be just some collateral damage
>> in the name of progress.  Or could be something else entirely!
> 
> 
> I think
> [PATCH 15/66] kconfig: gconf: remove gtk_tree_view_set_rules_hint() calls
> affected this.
> 

Yes, that likely did it.

> gtk_tree_view_set_rules_hint() is deprecated.
> 
> 
> The comment says "just do it in a theme"
>  https://gitlab.gnome.org/GNOME/gtk/-/blob/3.14.0/gtk/gtktreeview.c#L11875
> 
> But, I do not know which theme should be applied.

Agreed. I didn't find any help on that subject either.

Thanks.


-- 
~Randy