linux-kernel - [PATCH] irqchip/qcom-irq-combiner: Rename driver struct to end in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250630172333.73614-2-u.kleine-koenig@baylibre.com>
Date: Mon, 30 Jun 2025 19:23:32 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Agustin Vega-Frias <agustinv@...eaurora.org>,
	Marc Zyngier <maz@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Cc: linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Markus Schneider-Pargmann <msp@...libre.com>
Subject: [PATCH] irqchip/qcom-irq-combiner: Rename driver struct to end in _driver

The modpost section mismatch checks are more lax for objects that have a
name that ends in "_probe". This is not justified here though, so rename
the driver struct according to the usual naming choice.

Note that this change indeed results in modpost identifying a section
mismatch in this driver. This is not a false positive and should be
fixed by either converting the driver to use platform_driver_probe() or
by dropping __init from the .probe() callback. This problem was
introduced in commit f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner
driver").

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
---
Hello,

I don't know if platform_driver_probe() works here, it might happen that
the driver is probed before the matching device appears. As I don't have
a machine with such a device I won't create a patch fixing the issue,
but if you have questions don't hesitate to ask.

Please consider this patch as a bug report and better only apply it when
the issue is addressed to not result in build regressions.

Best regards
Uwe

 drivers/irqchip/qcom-irq-combiner.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/qcom-irq-combiner.c b/drivers/irqchip/qcom-irq-combiner.c
index 18e696dc7f4d..e92baf20c7ff 100644
--- a/drivers/irqchip/qcom-irq-combiner.c
+++ b/drivers/irqchip/qcom-irq-combiner.c
@@ -266,11 +266,11 @@ static const struct acpi_device_id qcom_irq_combiner_ids[] = {
 	{ }
 };

-static struct platform_driver qcom_irq_combiner_probe = {
+static struct platform_driver qcom_irq_combiner_driver = {
 	.driver = {
 		.name = "qcom-irq-combiner",
 		.acpi_match_table = ACPI_PTR(qcom_irq_combiner_ids),
 	},
 	.probe = combiner_probe,
 };
-builtin_platform_driver(qcom_irq_combiner_probe);
+builtin_platform_driver(qcom_irq_combiner_driver);

base-commit: 1343433ed38923a21425c602e92120a1f1db5f7a
-- 
2.49.0