linux-kernel - Re: [char-misc-next v2 4/5] mei: more prints with client prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025063003-doable-magician-3218@gregkh>
Date: Mon, 30 Jun 2025 19:25:39 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Alexander Usyskin <alexander.usyskin@...el.com>
Cc: Reuven Abliyev <reuven.abliyev@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [char-misc-next v2 4/5] mei: more prints with client prefix

On Mon, Jun 30, 2025 at 12:19:41PM +0300, Alexander Usyskin wrote:
> Use client-aware print macro instead of
> usual device print in more places.

Why?  This changes the output of the driver.

> 
> Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com>
> ---
>  drivers/misc/mei/hbm.c       | 14 ++++-----
>  drivers/misc/mei/interrupt.c |  2 +-
>  drivers/misc/mei/main.c      | 55 +++++++++++++++++-------------------
>  3 files changed, 34 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c
> index 026b1f686c16..4fe9a2752d43 100644
> --- a/drivers/misc/mei/hbm.c
> +++ b/drivers/misc/mei/hbm.c
> @@ -510,7 +510,7 @@ int mei_hbm_cl_notify_req(struct mei_device *dev,
>  
>  	ret = mei_hbm_write_message(dev, &mei_hdr, &req);
>  	if (ret)
> -		dev_err(dev->dev, "notify request failed: ret = %d\n", ret);
> +		cl_err(dev, cl, "notify request failed: ret = %d\n", ret);

Why do you have a mei-specific debug printk macro anyway?  You really
shouldn't do that :(

This feels like a step backwards.

thanks,

greg k-h