linux-kernel - Re: [PATCH v5 4/4] drm/xe/xe_i2c: Add support for i2c in survivability mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wtuwnljkbqqmzvjc6kvdrjmpdcfo5pq6hslirf42wt5ncizzdt@6ofeiipffkcf>
Date: Mon, 30 Jun 2025 21:02:11 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@...el.com>, 
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, 
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Mika Westerberg <mika.westerberg@...ux.intel.com>, Jan Dabros <jsd@...ihalf.com>, Raag Jadav <raag.jadav@...el.com>, 
	"Tauro, Riana" <riana.tauro@...el.com>, "Adatrao, Srinivasa" <srinivasa.adatrao@...el.com>, 
	"Michael J. Ruhl" <michael.j.ruhl@...el.com>, intel-xe@...ts.freedesktop.org, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/4] drm/xe/xe_i2c: Add support for i2c in
 survivability mode

Hi Heikki and Riana,

> +err:
> +	/*
> +	 * But if it fails, device can't enter survivability

nitpick: the "But" follows the "if". As we don't have the "if"
anymore, the "But" leaves the reader a bit flubbergasted :-)

If you are going to resend, please, remove it. Otherwise it can
be improved before submitting the patch.

In any case,

Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com>

Andi