linux-kernel - Re: [PATCH v8 3/4] phy: rockchip-pcie: Enable all four lanes if required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGME5sh1fLJlmVCD@geday>
Date: Mon, 30 Jun 2025 18:43:02 -0300
From: Geraldo Nascimento <geraldogabriel@...il.com>
To: Heiko Stübner <heiko@...ech.de>
Cc: linux-rockchip@...ts.infradead.org,
	Shawn Lin <shawn.lin@...k-chips.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Rick wertenbroek <rick.wertenbroek@...il.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Valmantas Paliksa <walmis@...il.com>, linux-phy@...ts.infradead.org,
	linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 3/4] phy: rockchip-pcie: Enable all four lanes if
 required

On Mon, Jun 30, 2025 at 11:33:19PM +0200, Heiko Stübner wrote:
> Am Montag, 30. Juni 2025, 20:22:01 Mitteleuropäische Sommerzeit schrieb Geraldo Nascimento:
> > Current code enables only Lane 0 because pwr_cnt will be incremented on
> > first call to the function. Let's reorder the enablement code to enable
> > all 4 lanes through GRF.
> > 
> > Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
> > Reviewed-by: Robin Murphy <robin.murphy@....com>
> > 
> > Signed-off-by: Valmantas Paliksa <walmis@...il.com>
> > Signed-off-by: Geraldo Nascimento <geraldogabriel@...il.com>
> 
> hmm, if Valmantas is the original author you should probably keep that authorship
>   git commit --amend --author="Valmantas Paliksa <walmis@...il.com>"
> should do the trick.
> 
> The first signed-off should be from the patch author, then your signed-off
> indicates you handling the patch later as part of this series.
> 
> [or, if you modified the code of the patch heavily, Co-developed-by could
>  also be appropriate]
> 

Hi Heiko,

thanks for the pointer on doing things right. I'd hate to appropriate
someone's else work. I already emailed Valmantas and he's fine with
the inclusion of his signed-off, so let's give him due credit.

Geraldo Nascimento

> Heiko