linux-kernel - Re: [PATCH] media: cros-ec-cec: Add Fizz board variants, so driver can detect them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8b65585-18bb-435c-9667-b202fb768299@jjverkuil.nl>
Date: Mon, 30 Jun 2025 08:25:23 +0200
From: hans@...erkuil.nl
To: Pedro Nariyoshi <pedro.nariyoshi@...il.com>,
 Hans Verkuil <hverkuil@...all.nl>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Benson Leung <bleung@...omium.org>,
 Guenter Roeck <groeck@...omium.org>, linux-media@...r.kernel.org,
 chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Mr Chromebox <mrchromebox@...il.com>
Subject: Re: [PATCH] media: cros-ec-cec: Add Fizz board variants, so driver
 can detect them

Hi Pedro,

On 28/06/2025 20:14, Pedro Nariyoshi wrote:
> I recently reflashed a Chromebox (Wukong variant of the Fizz board) with
> coreboot and I noticed that the cec driver refused to load with a bit of
> tinkering, I realized that the dmi_match_table was expecting the product
> name to be Fizz, but `dmidecode` reports `Wukong` as the product name. I
> am not sure if this is the best approach, but adding this patch lets me
> load the driver and it works properly.
> 
> Alternatively, we could instead match the DMI_PRODUCT_FAMILY, instead of
> DMI_SYS_VENDOR and DMI_PRODUCT_NAME. In my board at least, that says
> "Google_Fizz".
> 
> I am open to suggestions for alternative solutions and I hope I did't
> break any rules (this is my first kernel patch). (And sorry for the
> previous submissions with errors in the subject line)
> 
> Signed-off-by: Pedro Nariyoshi <pedro.nariyoshi@...il.com>

Thank you for your patch, but I would like to have someone from Google
review this as well.

The number of entries keeps increasing, so perhaps switching to
DMI_PRODUCT_FAMILY would make sense. But I have no insight in how this
is done internally at Google.

One question for Pedro: where did you get all the other code names
from? Based on the commit message you have the Wukong variant, but how
did you find all the other variants?

Regards,

	Hans

> ---
>  drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 419b9a7abcce..a26473c3cd84 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -302,8 +302,15 @@ static const char *const port_ab_conns[] = { "Port A", "Port B", NULL };
>  static const char *const port_d_conns[] = { "Port D", NULL };
>  
>  static const struct cec_dmi_match cec_dmi_match_table[] = {
> -	/* Google Fizz */
> +	/* Google Fizz and variants*/
>  	{ "Google", "Fizz", "0000:00:02.0", port_b_conns },
> +	{ "Google", "Bleemo", "0000:00:02.0", port_b_conns },
> +	{ "Google", "Excelsior", "0000:00:02.0", port_b_conns },
> +	{ "Google", "Jax", "0000:00:02.0", port_b_conns },
> +	{ "Google", "Kench", "0000:00:02.0", port_b_conns },
> +	{ "Google", "Sion", "0000:00:02.0", port_b_conns },
> +	{ "Google", "Teemo", "0000:00:02.0", port_b_conns },
> +	{ "Google", "Wukong", "0000:00:02.0", port_b_conns },
>  	/* Google Brask */
>  	{ "Google", "Brask", "0000:00:02.0", port_b_conns },
>  	/* Google Moli */