linux-kernel - Re: [PATCH] media: cros-ec-cec: Add Fizz board variants, so driver can detect them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aGTXF-FQoJx3bMYB@google.com>
Date: Wed, 2 Jul 2025 06:52:07 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Pedro Nariyoshi <pedro.nariyoshi@...il.com>
Cc: Hans Verkuil <hverkuil@...all.nl>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Benson Leung <bleung@...omium.org>,
	Guenter Roeck <groeck@...omium.org>, linux-media@...r.kernel.org,
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Mr Chromebox <mrchromebox@...il.com>
Subject: Re: [PATCH] media: cros-ec-cec: Add Fizz board variants, so driver
 can detect them

On Sat, Jun 28, 2025 at 02:14:35PM -0400, Pedro Nariyoshi wrote:
> I recently reflashed a Chromebox (Wukong variant of the Fizz board) with
> coreboot and I noticed that the cec driver refused to load with a bit of
> tinkering, I realized that the dmi_match_table was expecting the product
> name to be Fizz, but `dmidecode` reports `Wukong` as the product name. I
> am not sure if this is the best approach, but adding this patch lets me
> load the driver and it works properly.
> 
> Alternatively, we could instead match the DMI_PRODUCT_FAMILY, instead of
> DMI_SYS_VENDOR and DMI_PRODUCT_NAME. In my board at least, that says
> "Google_Fizz".

Yes, please extend the table of `struct cec_dmi_match` and support
DMI_PRODUCT_FAMILY match in cros_ec_cec_find_hdmi_dev().

> I am open to suggestions for alternative solutions and I hope I did't
> break any rules (this is my first kernel patch). (And sorry for the
> previous submissions with errors in the subject line)

Thank you for your patch. You could consider to move most of the additional
information after "---" in your patch (so that they won't be part of the
commit message).